LGTM Mary On 09/05/2012 02:47, Mary Ding wrote: > Hi: > > > > Can I have a code review for the following bug fix: > > 7161993 <http://monaco.us.oracle.com/detail.jsf?cr=7161993> > pep8 regression in > /usr/lib/python2.6/vendor-packages/solaris_install/target/logical.py > > Web rev is here: > > https://cr.opensolaris.org/action/browse/caiman/md5645/7161993 > > > Testing had been done this way: > > 1. Confirm that pep8 no longer complains about logica.py > > 2. I also ran slim_install_unit test and it was fine on osol-bldx and > osol-bldsp > > /net/osol-bldx.us.oracle.com/datapool/ding/7161993/slim_source/s11u1_15_test_result > /net/osol-bldsp.us.oracle.com/datapool/ding/7161993/slim_source/s11u1_15_test_result > > 3. I use DC to build all 5 isos and do install testing: > > AI sparc and x86 install - OK > TI sparc and x86 install - OK > LIve Media install - OK > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
