LGTM!
-Drew
On 5/9/12 7:59 AM, Susan Sohn wrote:
Drew, Darren,
Updated webrevs are at:
Full:
https://cr.opensolaris.org/action/browse/caiman/sohn/7102885_2/webrev.7102885_2
Diffs:
https://cr.opensolaris.org/action/browse/caiman/sohn/7102885_2_diffs/webrev.7102885_2.diffs
Sue
On 05/ 3/12 10:43 AM, Sue Sohn wrote:
Can I get a code review of the changes for:
PSARC/2012/142 installadm update-service
7102885 update a pkg(5) based service
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7102885/webrev.7102885
Tests:
Command line option validation and action (positive and negative)
Command restricted to pkg(5) based service aliases
Client installs of updated alias
Regression test of set-service -o aliasof and create-service
Ran unit tests (newly added tests pass and no new errors on existing
tests).
In addition, QA has executed all test assertions from the test plan at:
http://onwiki.us.oracle.com/bin/view/SolarisQE/+ISIM+Improvements+Test+Plan
on both sparc and x86 AI servers and has run the installadm test
suites (no regressions).
Supporting requests filed:
o Test Suites:
QE Request: https://sqe-osso.us.oracle.com/sqept/view.php?ticket=29
o Install Guide:
7162893 Install Guide should be updated with new installadm
update-service subcommand, PSARC/2012/142
o installadm(1m) manpage:
7162895 update installadm(1m) man page to include new update-service
subcommand, PSARC/2012/142
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
