Hi Jack,
Thanks for reviewing the code. There are comments inline. I will send
out another webrev when I have completed making all of the changes.
Harold
On 05/11/12 11:57, Jack Schwartz wrote:
Hi Harold.
I spent some time to digest target_selection.py. I have a few
nits/questions:
Nit: 2823: Re-apportion the words of the comment for more even lines.
Done.
3784-3789: I know you didn't do this, the comments look incorrect
here. Where would minimum_target_size get set? Where does
Target(Target.DESIRED) get called?
_minimum_target_size gets set to None in TargetController.initialize.
If the external method TargetController.minimum_target_size is called
and the value of _minimum_target_size is None then it returns a default
minimum size value.
Target(Target.DESIRED) is called in TargetController.initialize.
Based on that the comments aren't incorrect. Maybe misleading since the
actions in the comments happen at a lower level.
Thanks,
Jack
On 05/10/12 12:51 PM, Harold Shaw wrote:
Dave Marker has already reviewed this but with the build 17-20 rule I
need to get 2 reviews, so can I get an additional code review for the
following bug:
CR: http://monaco.sfbay/detail.jsf?cr=7147174
There is an additional change that isn't noted in the webrev. I
moved line 194 in target_selection.py left by one tab. The function,
__pretty_print_disk, if called with a list of disks would only create
a string with the first disk in the list. The return statement
needed to be moved out of the loop.
Webrev: https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174_2/
All of the target unit tests were run on both Sparc and x86. All of
the tests passed. Unit tests were added to both the Sparc and x86
target selection tests to verify the fix.
A number of AI manifests were written to test different sets of disk
specifications in the manifest. They were run using auto-install and
stopping before the target instantiation checkpoint. These manifests
have been sent to QE to be used as a basis for a new test suite that
will be able to test a large set of manifests that describe a range
of disk environments.
Full Installs were run with the default manifest and 2 of the test
manifests to ensure proper layout and installation.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
