Looks good to me Mary.
--Karen
On 05/16/12 02:35 PM, Mary Ding wrote:
Hi:
Can I have a code review for the following bug fixes:
7155706 <http://monaco.us.oracle.com/detail.jsf?cr=7155706>
pylint errors in usr/src/lib/install_transfer/ips.py
7160785 <http://monaco.us.oracle.com/detail.jsf?cr=7160785>
pylint warnings in usr/src/cmd/distro_const/
7153262 <http://monaco.us.oracle.com/detail.jsf?cr=7153262>
new pep8 error in boot_archive_archive.py due to bugid 7073683
Web rev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7155706_7160785_7153262
Testing had been done this way:
1. Confirm that pep8 no longer complains.
2. Fix the pylint warnings for the following issues:
W0403 Relative import
C0301 Line too long
W0611 Unused import
W0105 Strings had no effect
3. I also ran slim_install_unit test and it was fine on osol-bldx and
osol-bldsp. All failures are known issues and there are no regression.
/net/osol-bldx.us.oracle.com//datapool/ding/7160785/slim_source/usr/src/tools/tests/test_result
/net/osol-bldsp.us.oracle.com/datapool/ding/7160785/slim_source/usr/src/tools/tests/test_result
4. I also update a sparc and x86 machines to do DC builds with my
install packages. All 5 isos were build and install testing is done:
AI sparc and x86 install - OK
TI sparc and x86 install - OK
LIve Media install - OK
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
