+1
On 05/16/12 12:53, Harold Shaw wrote:
Matt,
Thanks for catching that. I should know to never send out a code
review before I have completed testing. I have a set of test AI
manifests that I have been using to test my changes. The error was
flagged by these tests. It does point out that code path is not
covered by the unit tests. I will add a test for that and send out a
followup after I have completed all of the tests.
Harold
On 05/16/12 03:12, Matt Keenan wrote:
Harold,
I think i followed up a little quickly...
target_selection.py : 1658
Still refers to "discovered_disk" which now does not exist, as you've
replaced it with matched_disk. As this was not discovered during
testing (manual or automated), looks like this code path was not
accessed.
I'm guessing the code should be changed to :
zpool_map[devkey] = matched_disk.matches[0]
cheers
Matt
On 05/15/12 23:59, Harold Shaw wrote:
I have made the requested changes to this fix. I have included both
a full and differential webrev. Please feel free to comment. For
those of you that reviewed this round (Matt & Jack) would you mind
taking a look to see if it satisfies your concerns.
CR: http://monaco.sfbay/detail.jsf?cr=7147174
Differential webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174_diff
Full webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174_3
All of the target unit tests were run on both Sparc and x86. All of
the tests passed. Unit tests were added to both the Sparc and x86
target selection tests to verify the fix.
Thanks,
Harold
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
