Hi Swati -- Looks good. ginnie
On 05/22/12 04:14 PM, Swati Sarraf wrote:
Hi All, Can I have a code review for the following bug fix: 7163218: Typo in live CD GUI: Aggregration -> Aggregation http://monaco.us.oracle.com/detail.jsf?cr=7163218 Webrev link: https://cr.opensolaris.org/action/browse/caiman/ssarraf/7163218 Testing is done as follow: 1. Slim unit test and slim regression test done , result ok test result link : /net/osol-bldx/ssarraf/7163218_new/slimtest_7163218 2. hg nits , result OK 3. To test the fix, I booted the live CD image from USB stick and installed it on my system and checked the typo. Its showed bug fixed. DC image link: /net/osol-bldx/ssarraf/dc/livecd_7163218_new 4. As the change was made in xml file so do not need pep8 and pylint testing. Thanks Swati _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
