Thanks Dave,
Updated s/warning/debug/
cheers
Matt
On 05/22/12 23:22, Dave Miner wrote:
On 05/22/12 10:38, Matt Keenan wrote:
On 05/22/12 15:33, Dave Miner wrote:
On 05/22/12 09:46, Matt Keenan wrote:
Hi,
Can I get two pairs of eyes to look over this fix please:
Bug
http://monaco.us.oracle.com/detail.jsf?cr=7165978
7165978 AI should create VARSHARE with compression as per /var
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7165978
This bug was uncovered via zones testing. The default manifest for
zones
installation specifies a BE option to turn on compression for all
datasets created within that zone. However as VARSHARE is not within
the
BE it needs to inherit the compression property from var dataset that's
created within the BE.
The changes I've made allow for a user to still specify compression for
var and VARSHARE to be different via manually specification in an AI
manifest. A warning message is shown if they manually set it, but
installation will complete.
Why should this be a warning? It's valid, and is clearly a choice
they've made, so it seems like noise.
Dave
Just my own gut reaction that a warning might be appropriate, however I
still think something reflected in the log would be beneficial, so
possible changing this to debug would be more suitable ?
Debug is certainly fine with me.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
