Karen:

Thank you for the review. I still need one more code review for this.



On 05/23/12 01:36 PM, Karen Tung wrote:
Looks good to me Mary.

--Karen

On 05/23/12 01:11 PM, Mary Ding wrote:
Hi:

Can I get a code review for the following bug fix for usr/src/cmd/gui-install/aux/FINISH_PANEL.txt:

CR: http://monaco.sfbay/detail.jsf?cr=7157990 FINISH_PANEL.txt contains non-ASCII character (EN DASH: U+2013)


Web rev is here and is suggested by Takeshi-san:


https://cr.opensolaris.org/action/browse/caiman/md5645/7157990


Testing is done this way:

1. I do livecd DC build with my packages and do the install. I confirm that after install is done. I clicked on the Help Screen with Finish and confirm the non-ASCII character is gone.

2.  I also ran slim regression test and there is no failure:

Result is here: /net/tcu27-01/export/home/ding/7157990/slim_source/usr/src/tools/tests/test_result


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to