LGTM too... Thanks,
Darren. On 24/05/2012 05:12, Mary Ding wrote: > Karen: > > Thank you for your review. I still need one more code review for this fix. > > > ----- Original Message ----- > From: [email protected] > To: [email protected] > Cc: [email protected] > Sent: Wednesday, May 23, 2012 5:08:21 PM GMT -08:00 US/Canada Pacific > Subject: Re: [caiman-discuss] Code review request for 7161440 > > Looks good to me Mary. > > --Karen > > On 05/23/12 04:42 PM, Mary Ding wrote: >> Hi: >> >> >> Can I get a code review for the following bug fix >> forusr/src/cmd/distro_const/checkpoints/boot_archive_archive.py : >> >> CR: http://monaco.sfbay/detail.jsf?cr=7161440 remove >> kernel_cage_enable=0 from boot_archive_archive >> >> >> Web rev is here: >> >> https://cr.opensolaris.org/action/browse/caiman/md5645/7161440 >> >> >> Testing is done this way: >> >> The reason why kernel_cage_enabled=0 is added to workaround zfs >> kernel_cage bug 6985061 for sparc. >> It used to hang on low memory systems in S11 for sparc. This had been >> seen on sun4u with 1 GB to 2 GB of memory. We implement the >> workaround in boot_archive_archive.py with bugid 6979560. >> >> In S11u1, kernel_cage_enable is not supported any more after vm2 >> integration. Our Install Minimum memory requirement is also 1.5 GB >> for S11 FCS. >> >> I setup LDOM with 1.5 GB of memory for AI testing and confirmed that >> Install is successful. Thus it is save to remove the obselete >> kernel_cage_enable=0 from boot_archive_archive.py >> >> I use DC with my packages to do the build for AI. >> >> Before the fix, the following warning will be seen on sparc install: >> >> Sun Fire(TM) T1000, No Keyboard >> Copyright (c) 1998, 2010, Oracle and/or its affiliates. All rights >> reserved. >> OpenBoot 4.30.4.b, 8064 MB memory available, Serial #69329298. >> Ethernet address 0:14:4f:21:e1:92, Host ID: 8421e192. >> >> >> >> Boot device: /pci@7c0/pci@0/network@4:dhcp File and args: >> 1000 Mbps full duplex Link up >> Timed out waiting for BOOTP/DHCP reply >> <time unavailable> wanboot info: WAN boot messages->console >> <time unavailable> wanboot info: configuring >> /pci@7c0/pci@0/network@4:dhcp >> >> 1000 Mbps full duplex Link up >> <time unavailable> wanboot info: Starting DHCP configuration >> <time unavailable> wanboot info: DHCP configuration succeeded >> <time unavailable> wanboot progress: wanbootfs: Read 368 of 368 kB (100%) >> <time unavailable> wanboot info: wanbootfs: Download complete >> Thu May 24 00:26:28 wanboot progress: miniroot: Read 233508 of 233508 >> kB (100%) >> Thu May 24 00:26:28 wanboot info: miniroot: Download complete >> sorry, variable 'kernel_cage_enable' is not defined in the 'kernel' >> SunOS Release 5.11 Version 11.1 64-bit >> Copyright (c) 1983, 2012, Oracle and/or its affiliates. All rights >> reserved. >> >> >> After the fix, the warning is gone: >> >> SPARC T4-2, No Keyboard >> Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights >> reserved. >> OpenBoot 4.33.6.a, 1536 MB memory available, Serial #77433574. >> Ethernet address 8:0:20:9d:8a:e6, Host ID: 849d8ae6. >> >> >> >> Boot device: /virtual-devices@100/channel-devices@200/network@0:dhcp >> File and args: >> <time unavailable> wanboot info: WAN boot messages->console >> <time unavailable> wanboot info: configuring >> /virtual-devices@100/channel-devices@200/network@0:dhcp >> >> <time unavailable> wanboot info: Starting DHCP configuration >> <time unavailable> wanboot info: DHCP configuration succeeded >> <time unavailable> wanboot progress: wanbootfs: Read 368 of 368 kB (100%) >> <time unavailable> wanboot info: wanbootfs: Download complete >> Thu May 24 00:18:32 wanboot progress: miniroot: Read 233467 of 233467 >> kB (100%) >> Thu May 24 00:18:32 wanboot info: miniroot: Download complete >> SunOS Release 5.11 Version 11.1 64-bit >> Copyright (c) 1983, 2012, Oracle and/or its affiliates. All rights >> reserved. >> Remounting root read/write >> Probing for device nodes ... >> Preparing network image for use >> Downloading solaris.zlib >> --2012-05-23 23:24:34-- >> http://10.134.125.92:5555/export/home/images/mary_sparc//solaris.zlib >> Connecting to 10.134.125.92:5555... connected. >> HTTP request sent, awaiting response... 200 OK >> Length: 130169344 (124M) [text/plain] >> Saving to: `/tmp/solaris.zlib' >> >> 17% [=====> ] 22,597,768 >> 108M/s 34% [============> ] >> 45,482,000 108M/s 52% >> [===================> ] 68,356,632 >> 109M/s 69% [==========================> ] >> 90,649,648 108M/s 87% >> [=================================> ] 113,533,624 >> 108M/s 100%[======================================>] >> 130,169,344 108M/s in 1.1s >> >> 2012-05-23 23:24:36 (108 MB/s) - `/tmp/solaris.zlib' saved >> [130169344/130169344] >> >> Downloading solarismisc.zlib >> --2012-05-23 23:24:36-- >> http://10.134.125.92:5555/export/home/images/mary_sparc//solarismisc.zlib >> Connecting to 10.134.125.92:5555... connected. >> HTTP request sent, awaiting response... 200 OK >> Length: 11413504 (11M) [text/plain] >> Saving to: `/tmp/solarismisc.zlib' >> >> 0% [ ] 0 >> --.-K/s 100%[======================================>] >> 11,413,504 --.-K/s in 0.1s >> >> 2012-05-23 23:24:36 (107 MB/s) - `/tmp/solarismisc.zlib' saved >> [11413504/11413504] >> >> Downloading .image_info >> --2012-05-23 23:24:36-- >> http://10.134.125.92:5555/export/home/images/mary_sparc//.image_info >> Connecting to 10.134.125.92:5555... connected. >> HTTP request sent, awaiting response... 200 OK >> Length: 98 [text/plain] >> Saving to: `/tmp/.image_info' >> >> 0% [ ] 0 >> --.-K/s 100%[======================================>] >> 98 --.-K/s in 0s >> >> 2012-05-23 23:24:36 (6.39 MB/s) - `/tmp/.image_info' saved [98/98] >> >> Done mounting image >> Configuring devices. >> Hostname: solaris >> Service discovery phase initiated >> Service name to look up: mary_sparc-narn >> Service discovery over multicast DNS failed >> Service mary_sparc-narn located at 10.134.125.92:5555 will be used >> Service discovery finished successfully >> Process of obtaining install manifest initiated >> Using the install manifest obtained via service discovery >> >> Automated Installation started >> The progress of the Automated Installation will be output to the console >> Detailed logging is in the logfile at /system/volatile/install_log >> Press RETURN to get a login prompt at any time. >> >> >> solaris console login: 23:27:03 Install Log: >> /system/volatile/install_log >> 23:27:03 Using XML Manifest: /system/volatile/ai.xml >> 23:27:03 Using profile specification: /system/volatile/profile >> 23:27:04 Using service list file: /var/run/service_list >> 23:27:04 Starting installation. >> 23:27:04 0% Preparing for Installation >> 23:27:04 100% manifest-parser completed. >> 23:27:04 0% Preparing for Installation >> 23:27:04 1% Preparing for Installation >> 23:27:04 2% Preparing for Installation >> 23:27:05 3% Preparing for Installation >> 23:27:05 4% Preparing for Installation >> 23:27:05 7% target-discovery completed. >> 23:27:05 Selected Disk(s) : c3d0 >> 23:27:05 13% target-selection completed. >> 23:27:05 17% ai-configuration completed. >> 23:27:05 19% var-share-dataset completed. >> 23:27:11 21% target-instantiation completed. >> 23:27:11 21% Beginning IPS transfer >> 23:27:11 Creating IPS image >> 23:27:11 Refreshing Catalog ... Started. >> 23:27:30 Refreshing Catalog ... Done. >> 23:27:46 Installing packages from: >> 23:27:46 solaris >> 23:27:46 origin: http://ipkg.us.oracle.com/solaris11/dev/ >> 23:27:47 Refreshing Catalog ... Started. >> 23:27:47 Refreshing Catalog ... Done. >> 23:27:47 Creating Plan ... Started. >> 23:28:37 Creating Plan ... Done. >> 23:28:38 Please review the licenses for the following packages >> post-install: >> 23:28:38 consolidation/osnet/osnet-incorporation (automatically >> accepted, >> 23:28:38 not displayed) >> 23:28:38 Package licenses may be viewed using the command: >> 23:28:38 pkg info --license <pkg_fmri> >> 23:28:38 Download Phase ... Started. >> 23:28:38 Download: driver/storage/mpt ... >> 23:28:38 Download: library/libtool/libltdl ... >> 23:28:38 Download: network/rsync ... >> 23:28:38 Download: install/js2ai ... >> 23:28:39 Download: driver/storage/aac ... >> 23:28:39 Download: system/kernel/security/gss ... >> 23:28:39 Download: system/virtual-console ... >> 23:28:39 Download: system/management/ocm ... >> 23:28:50 Download: driver/serial/usbser_edge ... >> 23:28:50 Download: release/name ... >> 23:28:50 Download: developer/build/make ... >> 23:28:50 Download: developer/build/gnu-make ... >> 23:28:50 Download: system/prerequisite/gnu ... >> 23:28:50 Download: system/io/fc/fc-scsi ... >> 23:28:50 Download: system/library/platform ... >> 23:28:51 Download: library/python-2/lxml-26 ... >> 23:28:51 Download: system/keyboard/keyboard-utilities ... >> 23:28:51 Download: package/pkg/zones-proxy ... >> 23:28:51 Download: driver/network/ethernet/nxge ... >> 23:28:51 Download: consolidation/l10n/l10n-incorporation ... >> 23:28:51 Download: driver/storage/pcata ... >> 23:28:51 Download: data/docbook/docbook-dtds ... >> 23:28:52 Download: entire ... >> 23:28:52 Download: system/dynamic-reconfiguration ... >> 23:28:52 Download: print/filter/a2ps ... >> 23:28:53 Download: network/ftp ... >> 23:28:53 Download: compress/gzip ... >> 23:28:53 Download: driver/serial/pcser ... >> 23:28:53 Download: driver/storage/glm ... >> 23:28:53 Download: consolidation/ldoms/ldoms-incorporation ... >> 23:28:53 Download: system/library/storage/snia-ima ... >> 23:28:53 Download: system/library/storage/scsi-plugins ... >> 23:28:53 Download: driver/network/wlan/pcwl ... >> 23:28:53 Download: x11/library/libpthread-stubs ... >> 23:28:53 Download: developer/versioning/sccs ... >> 23:28:54 Download: system/management/rad/module/rad-smf ... >> 23:28:54 Download: service/network/ssh ... >> 23:28:54 Download: library/zlib ... >> 23:28:54 Download: system/data/timezone ... >> 23:28:55 Download: system/library/policykit ... >> 23:28:55 Download: system/data/terminfo/terminfo-core ... >> 23:28:55 Download: system/fault-management/snmp-notify ... >> 23:28:55 Download: consolidation/sic_team/sic_team-incorporation ... >> 23:28:55 Download: x11/library/libxpm ... >> 23:28:55 Download: network/ping ... >> 23:28:55 Download: library/readline ... >> 23:28:55 Download: service/network/dns/mdns ... >> 23:28:56 Download: developer/assembler ... >> 23:28:56 Download: library/security/libgpg-error ... >> 23:28:56 Download: system/management/ilomconfig ... >> 23:28:56 Download: consolidation/SunVTS/SunVTS-incorporation ... >> 23:28:56 Download: system/file-system/pcfs ... >> 23:28:56 Download: system/xopen/xcu4 ... >> 23:28:56 Download: system/xopen/xcu6 ... >> 23:28:57 Download: system/manual/locale ... >> 23:28:57 Download: system/io/infiniband ... >> 23:28:57 Download: driver/graphics/mga ... >> 23:28:57 Download: system/library/install ... >> 23:28:57 Download: system/data/hardware-registry ... >> 23:28:57 Download: system/kernel/io-performance-counters ... >> 23:28:58 Download: system/library/storage/snia-mpapi ... >> 23:28:58 Download: network/finger ... >> 23:28:58 Download: system/io/fc/fc-san-management ... >> 23:28:58 Download: driver/network/ethernet/eri ... >> 23:28:58 Download: diagnostic/top ... >> 23:28:58 Download: diagnostic/tcpdump ... >> 23:28:58 Download: system/kernel ... >> 23:29:03 Download: system/library/security/libgcrypt ... >> 23:29:04 Download: driver/network/ethernet/e1000g ... >> 23:29:04 Download: system/io/fc/fc-port ... >> 23:29:04 Download: driver/serial/usbsksp/usbs49_fw ... >> 23:29:04 Download: x11/library/libxcb ... >> 23:29:04 Download: consolidation/java/java-incorporation ... >> 23:29:04 Download: system/firmware-utilities ... >> 23:29:04 Download: compress/bzip2 ... >> 23:29:04 Download: x11/header/x11-protocols ... >> 23:29:05 Download: system/locale ... >> 23:29:06 Download: driver/network/ethernet/yge ... >> 23:29:06 Download: consolidation/sfw/sfw-incorporation ... >> 23:29:06 Download: install/installadm ... >> 23:29:07 Download: library/libtecla ... >> 23:29:07 Download: driver/network/ethernet/igb ... >> 23:29:07 Download: system/install/tests ... >> 23:29:07 Download: library/python-2/pyopenssl-26 ... >> 23:29:07 Download: database/sqlite-3 ... >> 23:29:07 Download: library/security/openssl ... >> 23:29:08 Download: system/network/ppp/pppdump ... >> 23:29:08 Download: driver/network/ethernet/hme ... >> 23:29:08 Download: service/network/tftp ... >> 23:29:08 Download: release/notices ... >> 23:29:08 Download: driver/serial/usbsacm ... >> 23:29:08 Download: system/io/usb ... >> 23:29:09 Download: library/unixodbc ... >> 23:29:09 Download: service/network/smtp/sendmail ... >> 23:29:10 Download: crypto/pwgen ... >> 23:29:10 Download: print/cups/filter/foomatic-db-engine ... >> 23:29:10 Download: image/library/libpng ... >> 23:29:10 Download: system/resource-mgmt/resource-caps ... >> 23:29:10 Download: system/fault-management/fm-snmp-mib ... >> 23:29:10 Download: system/floating-point-scrubber ... >> 23:29:10 Download: system/boot/wanboot ... >> 23:29:10 Download: package/svr4 ... >> 23:29:11 Download: system/library/libdbus-glib ... >> 23:29:11 Download: archiver/gnu-tar ... >> 23:29:11 Download: system/library/processor ... >> 23:29:11 Download: system/zones ... >> 23:29:11 Download: text/doctools ... >> 23:29:13 Download: system/core-os ... >> 23:29:24 Download: text/less ... >> 23:29:24 Download: >> system/domain-service-processor-protocol/sparc-enterprise ... >> 23:29:24 Download: system/library ... >> 23:29:33 Download: system/fault-management/smtp-notify ... >> 23:29:33 Download: system/storage/iscsi/iscsi-iser ... >> 23:29:33 Download: x11/library/toolkit/libxt ... >> 23:29:34 Download: web/wget ... >> 23:29:34 Download: system/library/openmp ... >> 23:29:34 Download: service/security/kerberos-5 ... >> 23:29:34 Download: system/resource-mgmt/dynamic-resource-pools ... >> 23:29:34 Download: driver/network/wlan/pcan ... >> 23:29:34 Download: driver/network/ethernet/ixgbe ... >> 23:29:34 Download: system/network/routing ... >> 23:29:35 Download: system/resource-mgmt/resource-pools ... >> 23:29:35 Download: system/io/infiniband/ib-device-mgt-agent ... >> 23:29:35 Download: system/library/security/libsasl ... >> 23:29:35 Download: library/pcre ... >> 23:29:36 Download: consolidation/osnet/osnet-incorporation ... >> 23:29:36 Download: text/gnu-diffutils ... >> 23:29:36 Download: driver/serial/usbftdi ... >> 23:29:36 Download: library/python-2/pyopenssl ... >> 23:29:36 Download: print/lp/filter/foomatic-rip ... >> 23:29:36 Download: text/spelling-utilities ... >> 23:29:36 Download: library/apr-util-13/dbd-sqlite ... >> 23:29:36 Download: naming/ldap ... >> 23:29:36 Download: driver/network/ethernet/sxge ... >> 23:29:36 Download: system/io/infiniband/ethernet-over-ib ... >> 23:29:37 Download: developer/base-developer-utilities ... >> 23:29:37 Download: data/docbook/docbook-style-xsl ... >> 23:29:39 Download: system/kernel/secure-rpc ... >> 23:29:40 Download: diagnostic/ddu/locale ... >> 23:29:40 Download: system/library/libdbus ... >> 23:29:40 Download: driver/fc/socal ... >> 23:29:40 Download: driver/crypto/n2cp ... >> 23:29:40 Download: library/python-2/mako ... >> 23:29:40 Download: diagnostic/scanpci ... >> 23:29:40 Download: system/domain-configuration/sparc-enterprise ... >> 23:29:40 Download: library/python-2/mako-26 ... >> 23:29:40 Download: text/gnu-grep ... >> 23:29:40 Download: system/kernel/cpu/sun4v ... >> 23:29:40 Download: system/fru-id ... >> 23:29:41 Download: >> consolidation/solaris_re/solaris_re-incorporation ... >> 23:29:41 Download: consolidation/cacao/cacao-incorporation ... >> 23:29:41 Download: consolidation/dbtg/dbtg-incorporation ... >> 23:29:41 Download: library/python-2/ply ... >> 23:29:41 Download: print/cups/hal-cups-utils ... >> 23:29:41 Download: security/bart ... >> 23:29:41 Download: shell/zsh ... >> 23:29:43 Download: system/management/rad/client/rad-java ... >> 23:29:43 Download: developer/debug/mdb ... >> 23:29:46 Download: diagnostic/ddu/text ... >> 23:29:46 Download: system/device-administration ... >> 23:29:47 Download: media/xorriso ... >> 23:29:47 Download: shell/tcsh ... >> 23:29:47 Download: system/io/ultra-wideband ... >> 23:29:47 Download: driver/network/ethernet/ixgb ... >> 23:29:47 Download: driver/graphics/efb ... >> 23:29:48 Download: driver/storage/smp ... >> 23:29:48 Download: system/network/ppp ... >> 23:29:48 Download: system/fault-management ... >> 23:29:49 Download: system/management/rad ... >> 23:29:49 Download: driver/parallel/ecpp ... >> 23:29:50 Download: system/storage/raid-utilities ... >> 23:29:50 Download: driver/serial/usbsprl ... >> 23:29:50 Download: driver/network/ethernet/xge ... >> 23:29:50 Download: system/zones/brand/brand-solaris10 ... >> 23:29:50 Download: consolidation/desktop/gnome-incorporation ... >> 23:29:50 Download: text/gnu-sed ... >> 23:29:50 Download: compress/unzip ... >> 23:29:50 Download: system/storage/removable-media ... >> 23:29:51 Download: system/file-system/autofs ... >> 23:29:51 Download: x11/library/libxi ... >> 23:29:51 Download: system/io/infiniband/reliable-datagram-sockets ... >> 23:29:51 Download: system/management/rad/client/rad-python ... >> 23:29:51 Download: service/network/ntp ... >> 23:29:52 Download: system/io/infiniband/rpc-over-rdma ... >> 23:29:52 Download: driver/storage/ssd ... >> 23:29:52 Download: library/perl-5/xml-parser ... >> 23:29:52 Download: media/cdrw ... >> 23:29:52 Download: library/python-2/m2crypto-26 ... >> 23:29:52 Download: runtime/python-26 ... >> 23:29:56 Download: system/management/snmp/net-snmp/documentation ... >> 23:29:58 Download: system/storage/iscsi/iscsi-initiator ... >> 23:29:58 Download: system/io/fc/fc-fabric ... >> 23:29:58 Download: compress/p7zip ... >> 23:29:59 Download: x11/compatibility/links-xorg ... >> 23:29:59 Download: consolidation/desktop/desktop-incorporation ... >> 23:29:59 Download: compress/zip ... >> 23:29:59 Download: library/perl-5/xml-parser-512 ... >> 23:29:59 Download: library/ncurses ... >> 23:30:03 Download: system/network/ppp/tunnel ... >> 23:30:03 Download: print/filter/hplip ... >> 23:30:07 Download: terminal/screen ... >> 23:30:07 Download: diagnostic/spray ... >> 23:30:07 Download: shell/pipe-viewer ... >> 23:30:07 Download: service/network/dns/bind ... >> 23:30:07 Download: library/python-2/cherrypy ... >> 23:30:07 Download: system/data/terminfo ... >> 23:30:26 Download: system/network ... >> 23:30:27 Download: security/nss-utilities ... >> 23:30:27 Download: system/kernel/suspend-resume ... >> 23:30:28 Download: library/apr-util-13/apr-ldap ... >> 23:30:28 Download: system/library/boot-management ... >> 23:30:28 Download: driver/network/ethernet/rge ... >> 23:30:28 Download: x11/library/libx11 ... >> 23:31:28 Download: print/psutils ... >> 23:31:29 Download: library/security/openssl/openssl-fips-140 ... >> >> >> >> >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
