OK, I'm happy enough, just wanted to be sure that it was considered. Thanks,
Darren. On 24/05/2012 13:52, Matt Keenan wrote: > On 05/24/12 13:23, Darren Kenny wrote: >> Hi Matt, >> >> In general it looks good, but I do have a question about the default >> mountpoint being used: >> >> 94 + default_mountpoint = "/" + fs.name + "/" >> >> >> Is it true that there is always a / at the end of the mountpoint? >> > > From what I can see in logical.py yes. > >> Is it not possible that someone specifies the mountpoint as simply /mnt >> as opposed to /mnt/ > > Someone could specify this and this as far as I can see indicates they > have specified it manually in the manifest, and therefore we actually > want to set the zfs option as well. > >> >> If so, I would suggest always ensuring the / is at the end of the string, >> if not already there, before doing the comparison. >> > > Based on above comment, I'd recommend not to. Unless of course there is > some better way of determining Target Discovery filled in mounpoint > itself, rather than from a manifest. > > cheers > > Matt > >> Thanks, >> >> Darren. >> >> On 24/05/2012 12:09, Matt Keenan wrote: >>> Hi, >>> >>> Can I get a pair of eyes on a fix for bug : >>> >>> Bug; >>> 7171068 booting zones with non-root users in SC config profiles leads to >>> svc:/filesystem/local in mainteance >>> http://monaco.us.oracle.com/detail.jsf?cr=7171068 >>> >>> Webrev: >>> https://cr.opensolaris.org/action/browse/caiman/mattman/7171068/ >>> >>> >>> Bug is caused by fix for 7166325, which attempted to fix where >>> mountpoints even if specified in Manifest were ignored during zones >>> creation. >>> >>> What was not realized during this fix is that Target Discovery will in >>> 99% of cases always set the mountpoint property of a filesystem during >>> discovery, regardless of whether it's specified in the manifest or not. >>> >>> Because of this after fix for 7166325, ALL datasets being created in a >>> zone were now explicit setting their mountpoint. This should not be the >>> case, in particular rpool/export/home needs to inherit it's mountpoint >>> from it's parent. Mountpoint setting should only happen where the >>> mountpoint differs from the default mountpoint as set by Target >>> Discovery. Target Discovery sets the mountpoint because DC needs to >>> know this. >>> >>> >>> - Tested installing zones where users are autoconfigured. >>> - Also ensured bug 7166325 is fixed with this new revision. >>> - Ran full suite of unit tests and no regressions found. >>> >>> regards >>> >>> Matt >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
