Hi Darren.
Pretty tricky navigation in _validate_input(). :)
Looks like you are unshackling yourself from IPS constraints and doing
the checking yourself instead. Assuming this is OK; not an expert here.
Nit: I suggest adding a comment that set_image_args() allows for an
empty _publ.
Code LGTM.
Thanks,
Jack
On 05/25/12 09:02 AM, Darren Kenny wrote:
Hi,
Could I please get two reviewers for the fix for the following bug:
7170813 AI fails on client hits assert (prefix or refresh_allowed)
or not repo_uri
[ http://monaco.us.oracle.com/detail.jsf?cr=7170813 ]
The webrev is at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7170813/webrev/
The problem here is that the prefix for the IPS publisher was being omitted
and because I added the refresh_allowed=False in a previous fix, I ended up
causing an assertion to fire for this scenario - which is one that I hadn't
tested for.
It turns out that this omission of the prefix is only permitted for the
first publisher that is used at creation time of the install image - any
other publisher must specify the prefix - this is enforced by the IPS
client API.
So I added some code to also test this scenario, and generate a meaningful
error should the prefix be omitted from any additional publishers.
I verified that the scenario that caused the bug now works correctly, and
also that all the scenarios that cause the error to occur are correctly
caught.
I updated the test suite bug 7163961 to request for addition for tests for
these scenarios too.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
