Takeshi-san:

Thanks for the review. I still need one more review for this fix.



On 05/29/12 05:14 PM, Takeshi Asano wrote:
Hi Mary,

LGTM. Thank you for the fix.

Thanks,
Takeshi

On 2012年05月30日 04:42, Mary Ding wrote:
Hi:

Can I get two code reviews for the following bug fix for *usr/src/cmd/gui-install/xml/disk-discovery.xml:*

CR: http://monaco.sfbay/detail.jsf?cr=7171794 WPTG_TBT:SOLARIS:OTHER:Q&A207544: Non localizble content, a dot in .po file

Web rev is here:

https://cr.opensolaris.org/action/browse/caiman/md5645/7171794

Testing is done this way:

1. Without the fix, the usr/src/cmd/gui-install/solaris_install_guiinstall.po contains the following lines:

#: xml/disk-discovery.xml:275 xml/disk-discovery.xml:308
#: xml/disk-discovery.xml:341
msgid "<span font_desc=\"Bold\">.</span>"
msgstr ""

2. After the fix, the usr/src/cmd/gui-install/solaris_install_guiinstall.po no longer contains the . in the po file.


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to