Geoffrey,
Looks good to me.

Harold

On 05/25/12 13:15, Geoffrey Hart wrote:
I will file a separate bug for this issue. I have looked into this and I can provide progress estimates for percent complete as the install works its magic. I will work in getting this done for you early next week.

- Geoffrey

On 05/25/12 07:29, Darren Kenny wrote:
Hi Geoffrey,

As mentioned in the bug, there is a distinct lack of information during the install phase, is this something that you are going to address as part of
this fix at all?

If not could we maybe please lot a separate bug for it, since right now it does look poor that we're providing all this information about the download
phase, but next to nothing for the install phase other than:

Install Phase ... Started.
Install Phase ... Done.

Which seems a bit lacking.

Thanks,

Darren.

On 24/05/2012 23:02, Geoffrey Hart wrote:
Afternoon all!

Could I please have a code review for:

BUG:
7125955 install_transfer/ips module should log more info about the
packages being installed into the image

CODE REVIEW:

https://cr.opensolaris.org/action/browse/caiman/ghart/Better_IPS_Logging/

DESCRIPTION:
This bug adds in publisher and version info to the logging of each IPS
package that is downloaded.

OLD LOG ENTRY:
2012-05-23 15:03:09,832   InstallationLogger.generated-transfer-1664-1
DEBUG
Download: driver/network/ethernet/elxl ...

NEW LOG ENTRY:
2012-05-24 14:01:10,294   InstallationLogger.generated-transfer-1580-1
DEBUG
Download: solaris/driver/storage/[email protected] ...


Testing done for this fix:
- Confirmed that new logging works and appears in this new format for
all packages
- Verified that the install still succeeds and the OS boots correctly
after install



Thanks,
-Geoffrey
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to