Hi Nirmal,
I'm ok with having check_auth_and_euid do nothing in the ParseOptions tests, but I'd like to see
another test class that tries to incorporate check_auth_and_euid as well. You could use SkipTest
(see test_engine_complex.py for example) or maybe you could do something where assertions depend on
permissions. I'll send you a snippet in a separate email.
Sue
On 05/30/12 12:04 AM, Nirmal Agarwal wrote:
Hi Sue,
Thanks for the review.
Please find the latest webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7170315-2/webrev/
Diff :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7170315-diff/webrev-diff/
On 05/29/12 22:26, Sue Sohn wrote:
Hi Nirmal,
Can you expand the comment on line 78 to explain *why* we check for -p
but not -P?
Done.
When you ran the unit tests, did you run as non-root?
I re-ran the unit test as normal user and fixed the issues.
Thanks
Nirmal
Sue
On 05/25/12 07:20 AM, Nirmal Agarwal wrote:
Hi all
Can I please get code review for CR 7170315 .
7170315 webservd lost permission to validate profile
webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7170315/webrev/
Testing :
--> Ran installadm validate -P without authorization and it works as
expected.
Slim Test: Pass
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
