Thank you very much for review, Karen.
I addressed all code review comments and updated webrev accordingly:
incremental:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7172606-1-diff/webrev-1-diff/
full:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7172606-1/webrev-1/
Retesting is now in progress...
Jan
On 06/ 1/12 06:05 PM, Karen Tung wrote:
Hi Jan,
usr/src/lib/install_transfer/cpio.py, line 501: I wonder logging this
information
with a log level of "info" is too strong. Since we are accepting an
empty
content list, I think it's better to log this at the "debug" level.
- Lines 474-495 in file usr/src/lib/install_transfer/media_transfer.py
are no longer
needed after your changes. They are implemented to download
the list of files under the "media" node of the transfer manifest.
Since we know
that there won't be any file to download anymore, we can safely remove
the code.
Thanks,
--Karen
On 06/ 1/12 04:07 AM, Jan Damborsky wrote:
Hi,
could I please ask two pairs of eyes to take a look at fix for
7172606 Network text install fails trying to download /etc/shadow
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7172606/webrev/
Thank you,
Jan
Testing done:
* built text/AI/LiveCD Sparc/x86 install images using modified Distro
Const.
* Verified that 'save area' now resides under /mnt/misc/save directory
(delivered by solarismisc.zlib archive)
* tested text (booted from media and network),
AI (booted from media and network),
LiveCD installations (Sparc and x86).
* run related unit tests (two unit tests modified)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
