Hi Tomas.

LGTM.

    Thanks,
    Jack

On 06/ 4/12 07:52 AM, Tomas Dzik wrote:
Hi all,
I would like to ask you for a code review for

7170320 installadm list profile showing None for Criteria (when Criteria is set)

Webrev is here:

https://cr.opensolaris.org/action/browse/caiman/t.dzik/7170320/

(It's one-liner and change is on line 307 - webrev does not mark just change in indentation as change in Frames diff.)


Testing:

1) Code is pep8 clean
2) I reproduced reported problem on virtual test machine
3) I copied changed list.py file to test system and checked that it resolved problem. 4) I run sudo ./slim_regression_test.py and it reported: No regressions found!

Best regards,

Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to