Hi Mary, The fix looks good to me,
Thanks, Darren. On 05/06/2012 02:12, Mary Ding wrote: > Hi: > > Can I get two code reviewers for the following bug fix: > > > CR: http://monaco.sfbay/detail.jsf?cr=7173297 Need to update slim_source > media-network-physical.xml to bring in fixes for 7152989 > > > Web rev is here and is suggested by Mark Haywood: > > > https://cr.opensolaris.org/action/browse/caiman/md5645/7173297 > > > Testing is done this way: > > > 1. I had ran slim regression test and there is no failure. Result is here: > > /net/osol-bldx/datapool/ding/7173297/slim_source/usr/src/tools/tests/test_result > > > 2. I had used DC to build all 5 isos and do testing as follow with the > latest on-nightly that had the fix for 7152989 and our install-nightly > that had the fix: > > x86: > > LiveCD install - confirm that init 0 can shutdown the system, also > confirm install works > TI install - confirm that init 0 can shutdown the system, also confirm > install works > AI install - confirm that init 0 can shutdown the system, also confirm > install works > net TI install - confirm that init 0 can shutdown the system, also > confirm install works > > sparc: > > TI install - confirm that init 0 can shutdown the system to the ok > prompt, also confirm install works > AI install - confirm that init 0 can shutdown the system to the ok > prompt, but install fails due to bugid 7174204 > net TI install - confirm that init 0 can shutdown the system to the ok > prompt, also confirm install works > > There is a problem with net AI sparc install which is related to > highlander and it is tracked under bugid 7174204. It is not related to > this fix. > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
