Hi Mary,
Looks good to me.
Thanks,
Nirmal
On 6/8/2012 10:26 PM, Mary Ding wrote:
Hi:
Can I get two code reviewers for the following bug fix relating to L10N:
CR: http://monaco.sfbay/detail.jsf?cr=7173456
"Local Disks" on "Discovery Selection" screen truncated when localized
in many languages
Web rev is here and is based on data provided by Takeshi Asano:
https://cr.opensolaris.org/action/browse/caiman/md5645/7173456
Based on data provided by Takeshi Asano, the ITEM_MAX_WIDTH needs to
be adjusted to 21.
Testing had been done this way:
1. I ran the slim_install_regression test and there is no failure:
2. I used DC to build the text install iso with my fix and the
install_mo from L10N for s11u1_18:
I tried the following L10N text install and confirmed the Discovery
Selection screen is displaying fine and there is no more truncation:
3. I also got Takeshi-san to test on all languages and he confirmed
the new fix works and there is no more truncation:
I tried ITEM_MAX_WIDTH=20 and 21 (19 and 20 columns room for label
respectively) and both worked fine with all languages we have.
Even using 21, the right label has 50 columns room (current
longest translation is 28 in French) so I suggest ITEM_MAX_WIDTH=21.
Attached is taken in German with ITEM_MAX_WIDTH=21 and using
dummy gauge string as LOCAL_DETAIL.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
