Looks ok to me.
-ethan
On 06/11/12 18:47, Jack Schwartz wrote:
Hello again, Ethan.
Just to be on the safe side, I've also changed ai_get_manifest.py to
check for prtconf -b returning the empty string along with successful
status. It should never do this, but the ARC case for prtconf -b
didn't say the commitment level was stable.
Webrev and delta updated, same location:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7162609_2
Thanks,
Jack
On 06/11/12 06:08 PM, Jack Schwartz wrote:
Hi Ethan.
Thanks for reviewing.
On 06/11/12 05:23 PM, Ethan Quach wrote:
Jack,
dmm.py
---------
357 - Should we be doing some kind of check against whether the
split succeeded or failed, or if prtconf_b is "" ?
I thought I'd tested this, but when I retested I got an exception...
good call...
I'll put it in a try/except as follows:
prtconf_b = self.call_cmd([PRTCONF, "-b"],
"Error getting system model / "
"platform via prtconf -b")
try:
os.environ["SI_MODEL"] = os.environ["SI_PLATFORM"] = \
prtconf_b.split(None, 1)[1]
except IndexError:
# Keep going. Script may not be using these variables.
# The fact that prtconf had an error is logged.
pass
support.py
--------------
494-495 - Just a nit, but could this be simplified to the following?
for (key, title, text) in self.CHOICES:
Updated webrev and delta are at:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7162609_2
Yup. Thanks.
Please bless and then I'll push tomorrow after retesting.
Thanks,
Jack
thanks,
-ethan
On 06/07/12 22:25, Jack Schwartz wrote:
Hi everyone.
Please review fixes for the following bugs:
7162609 Update Derived Manifests and AI manifest locator to use
prtconf -b instead of uname -i for SPARC
7092917 aimanifest commands reject valid subpaths with /[]@= in
their values in some cases
7173461 "No proxy"/"Proxy"/"Aggregation Hubs" exaplanations not
aligned and truncated when localized
I need to know by Monday that the first bug will get back, in order
to meet a deadline for manpage changes.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7162609_1
Testing:
7162609: booted SPARC system and ran the manifest locator with an
instrumented ai_get_manifest module to verify that the platform was
got via prtconf -b. Also ran auto_install with an instrumented
derived manifest module, and a derived manifest script that dumped
SI_MODEL and SI_PLATFORM. Will do the same for X86 before pushing.
7092917: Verified that the test case in the bug report failed
before the fix and succeeded after the fix. Also ran unit tests
successfully which found no regressions.
7173461: Ran sysconfig create-profile and verified that the network
configuration screen properly dealt with varying lengths of
left-side (title) strings.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
