Geoff,
The code changes in the webrev link you provided looks OK to me, but the below
snippet doesn't.
I am concerned because the snippet below shows only 1 change from line 116,
while the webrev shows the correct 2 changes on the correct line #s (119 and
208).
Additionally, this is supposed to be for fixing 7176183 (the P1 Mary filed)
which was caused by 7125955 putback, but not to fix 7125955 which was already
put back, so you should update the webrev to properly reflect that.
Also, the subject of this email as well as the description and information
below is still referencing 7125955 so they need to be adjusted as well.
Please make sure this is strictly adhered to going forward to avoid confusion
on reviewers' part, etc.
Martin
On 6/12/2012 3:17 PM, Geoffrey Hart wrote:
Could I please have a code review for:
BUG:
7125955 install_transfer/ips module should log more info about the packages
being installed into the image
CODE REVIEW:
https://cr.opensolaris.org/action/browse/caiman/ghart/Better_IPS_Logging_V2/
DESCRIPTION:
This bug adds in publisher and version info to the logging of each IPS package
that is downloaded.
This is a fix to my push that failed the checkin testing. The fix to the
previous version of the code is:
OLD LOG ENTRY:
2012-05-23 15:03:09,832 InstallationLogger.generated-transfer-1664-1 DEBUG
Download: driver/network/ethernet/elxl ...
NEW LOG ENTRY:
2012-06-12 10:12:08,733 InstallationLogger.generated-transfer-1577-1 DEBUG
Download:
pkg://solaris/driver/storage/[email protected],5.11-0.175.1.0.0.17.1:20120529T221102Z
...
diff -r 40a306a8de35 usr/src/lib/install_transfer/ips.py
--- a/usr/src/lib/install_transfer/ips.py Tue Jun 12 10:02:32 2012 +0200
+++ b/usr/src/lib/install_transfer/ips.py Tue Jun 12 13:56:06 2012 +0200
@@ -116,7 +116,7 @@
if self._dl_cur_pkg != self.cur_pkg:
if (self.cur_pkg in self._package_dict):
fmri = self._package_dict[self.cur_pkg]
- self._logger_output("Download: %s ...", fmri.get_fmri())
+ self._logger_output("Download: %s ..." % fmri.get_fmri())
else:
# only hits this at end when the cur_pkg becomes empty str
self._logger_output("Download: %s ..." % self.cur_pkg)
TESTING DONE FOR THIS RESPIN OF THE CODE:
- Confirmed that DC correctly builds and makes functional ISOs for txt,ai and
live install for x86 and sparc. Validated that the new logging is correct
- Confirmed that AI (x86 and sparc) works with new code and logging is correct.
- Confirmed that both code paths for progress tracking were covered (CLI and
Fancy logging).
Thanks,
-Geoffrey
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
