Hi Jan --
Thanks for the explanation. This looks good.
ginnie
On 6/15/12 2:56 AM, Jan Damborsky wrote:
Hi Ginnie,
thank you very much for review.
Code at lines 501-506 is exercised only if user previously selected
Manual Network configuration. That guarantees self.nic_iface is not None.
It gets either populated at line 84 in network_nic_select.py ifonly one
is NIC available (in which case NIC selection screen is skipped)
or at line 145 in network_nic_select.py (when 'NIC selection screen'
is left).
The check for None at line 410 in network_info.py was added, since as
a result
of this fix, get_nic_name() is now also called for newly introduced
'self.default_nic'
attribute which can be None in case get_default_nic() method does not
determine
default NIC (which is valid case - e.g. in non-global zones).
Jan
On 06/14/12 10:32 PM, Virginia Wray wrote:
Hi Jan --
Overall, it looks good.
One question...in network_info.py, at line 410, you added code to check
for None and return "". At lines 501 -506, is there a chance that
this will
return the quotes? If so, what happens in that case.
thanks,
ginnie
On 06/14/12 04:09 AM, Jan Damborsky wrote:
Hi,
could I please ask two pairs of eyes to take a look at fix for
7155952 textui needs better default network adapter
7171775 users.py:home_zfs_parent_exists() confused by
"/export/home/" mountpoint
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7171775/webrev-1/
Thank you,
Jan
Testing done:
* regression tests
- built text/AI/LiveCD Sparc/x86 install images.
- tested text (booted from media and network),
AI,
LiveCD installations (Sparc and x86).
* 7155952
tested on x4100 containing 4 NICs configured in following way:
net0 - not connected
net1 - not connected
net2 - connected (used as AI boot NIC)
net3 - not connected
- booted text installer from media and verified that
net2 was selected as default NIC
- booted text installer from AI server and verified that
net2 was selected as default NIC
* 7171775
tested in non-global zone, verified that
- creation of user account is enabled for both
rpool/export/home mountpointset to '/export/home'
as well as '/export/home/'.
- creation of user account is disabled if rpool/export/home
dataset set does not exist.
* run related unit tests
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
