Hi Mary --
This seems nit-picky, but I was wondering why at line 61, there is no
backslash
at the end of the line when all of the other lines have it. It doesn't
seem consistent
with the rest of the code in that section.
Otherwise, looks ok to me.
ginnie
On 06/15/12 11:58 AM, Mary Ding wrote:
Can I get two code reviewers for the following bug fix relating to
L10N and this should be in s11u1_19:
CR: http://monaco.sfbay/detail.jsf?cr=7161787
WPTG_TBT:Lint:CONCAT:Q&A204722-: Solaris 11.1 install_s11 T13Y issue
in solaris_install_text_menu.po
Web rev is here and it is based on suggestion from Takeshi Asano:
https://cr.opensolaris.org/action/browse/caiman/md5645/7161787
Testing had been done this way:
1. I confirmed the solaris_install_text_menu.po got the suggested fixes:
#: text-mode-menu.ksh:60 text-mode-menu.ksh:79
msgid "Terminal type (currently %s)"
msgstr ""
#: text-mode-menu.ksh:151
msgid "\"%s\" terminal type not supported."
msgstr ""
#: text-mode-menu.ksh:152
msgid ""
"Supported terminal types can be found by using the Shell to list the "
"contents of /usr/gnu/share/terminfo."
msgstr ""
2. Currently, solaris_install_text_menu.mo had not been integrated
yet. So I get a Japanese solaris_install_text_menu.mo from Takeshi-san
and do a DC build with my install packages and the special
solaris_install_text_menu.mo and test as follow
In English, this is what happen when you use the new text-mode-menu:
root@solaris:/var/svc/manifest# /usr/sbin/text-mode-menu
Welcome to the Oracle Solaris installation menu
1 Install Oracle Solaris
2 Install Additional Drivers
3 Shell
4 Terminal type (currently sun-color)
5 Reboot
Please enter a number [1]: 4
Indicate the type of terminal being used, such as:
dtterm CDE terminal emulator
xterm xterm
vt100 DEC VT100
Enter terminal type [sun-color]: junk
"junk" terminal type not supported.
Supported terminal types can be found by using the Shell to list the
contents of /usr/gnu/share/terminfo.
Enter terminal type [sun-color]:
In Japanese, this is what happen:
root@solaris:~# text-mode-menu
Oracle Solaris のインストールメニューへようこそ
1 Oracle Solaris のインストール
2 追加ドライバのインストール
3 シェル
4 端末のタイプ (現在 sun-color)
5 リブート
番号を入力してください[1]: 4
Indicate the type of terminal being used, such as:
dtterm CDE terminal emulator
xterm xterm
vt100 DEC VT100
Enter terminal type [sun-color]: junk
端末タイプ junk はサポートされていません。
サポートされている端末タイプを確認するには、シェルを使用して
/usr/gnu/share/terminfo の内容を一覧表示します。
Enter terminal type [sun-color]:
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
