Hi Takeshi.
Thanks for reviewing.
On 06/18/12 00:17, Takeshi Asano wrote:
Hi Jack,
(1) 7171004 Need to have sizing of OCM and ASR labels together...
[usr/src/cmd/system-config/support.py:989,990]
These two strings should now be applied _().
(Reported in 7170341 together with some other strings but
applying to the two strings has been postponed until fix
of this bug, I think.)
Fix is simple so re-review of the fix is not needed to me.
Thanks. Fixed.
(2) 7163452 support screen label "Support Registration" and error
messages...
This fix LGTM.
It'll be helpful if you can address similar bug 7173915 for
Disk Discovery screen. (Not needed to be in same changeset.)
I don't want to merge with this changeset. I'll work on it and try for
B19 in a separate push; not sure if there's enough time.
(3) 7061783 (warnings from xgettext), 7061783 ("neither"), 7091217
(ai-webserver strings)
LGTM.
(4) other CRs (7142587, 7091202, 7093415, 7091490)
Look not i18n bugfix and I'm not familiar with details of the
portions, but I didn't find problems in the changes.
Thanks,
Takeshi
Thanks again,
Jack
On 2012年06月18日 11:23, Jack Schwartz wrote:
Hi everyone.
Here is a webrev of various L10N-and message-related bugfixes. Lots
of small fixes.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7142587_1
Please review ASAP. These must get into B19 for U1 as they are L10N
or message fixes.
7171004 Need to have sizing of OCM and ASR labels together in order
for localization to work.
7177091 usr/src/cmd/system-config/summary.py had msgid localization
warning after changeset f77129fa2fe3
7163452 support screen label "Support Registration" and error
messages are not displayed localized
7142587 aimanifest command error msgs should be more explicit about
setting AI_MANIFEST environment variable
7093415 Better error messages for process_dtd.py / find_parent_path()
T13Y issue: incomplete/typo
7091490 Last error message in set_AI_schema needs some improvement
7091217 Messages in verifyXML.py need to be localized.
7161783 WPTG_TBT: Lint: SOLARIS: OTHER: Q&A204723: Solaris 11.1
install_s11
7091202 installadm create-profile needs better messages for invalid
criteria
Here is a list of which bugs go with which files:
usr/src/cmd/aimanifest/aimanifest.py 7142587
usr/src/cmd/gui-install/src/support_screen.py 7163452, 7161783
usr/src/cmd/system-config/support.py 7163452, 7171004
usr/src/cmd/system-config/summary.py 7177091
usr/src/cmd/text-install/summary.py 7177091
usr/src/lib/install_manifest_input/__init__.py 7093415
usr/src/lib/install_manifest_input/mim.py 7093415
usr/src/lib/install_manifest_input/process_dtd.py 7093415
usr/src/cmd/ai-webserver/data_files.py: 7091490, 7091202
usr/src/cmd/ai-webserver/verifyXML.py 7091202, 7091217
Testing:
7142587:
- Verified the error output when the AIM_MANIFEST environment
variable is not set.
- Verified that aimanifest still works when AIM_MANIFEST is set.
7163452:
- Set the Japanese locale and fired up the gui installer. Checked
that screens and popups related to OCM/ASR all show Japanese. (One
string does not, and that is due to 7163218 which just got fixed and
hasn't gone through L10N processing yet.)
7161783:
- Verified that the message in question prints correctly.
7171004:
- Verified that OCM and ASR hub labels (headers) are left-aligned,
and that the text fields to their right are aligned with each other
and accommodate different size headers.
- Verified that the proxy fields and headers also operate correctly
(similarly to OCM and ASR hub fields)
7177091:
- L10N build warning is gone.
- Verified the messages display properly for TI and sysconfig.
7093415:
- Verified that:
Ambiguity error: DTD shows multiple possible
absolute paths
gets displayed when multiple possible paths exist when placing a new
element with "aimanifest add".
- Verified that:
DTD shows no matching absolute path
gets displayed when the user gives a starting element that isn't in
the DTD)
7091490:
- Verified that the new error message displayed given the test case
in the bug report.
7091202:
-Verified that errors for invalid criteria ranges are all uniform for
installadm create-manifest:
installadm create-manifest ... -c ipv4=10:20:30:40
Error: Criteria error: Malformed IPV4 address in criteria
... -c mac=1.2.3.4.5.6-1.2.3.4.5.7
Error: Criteria error: Malformed MAC address in criteria
-c mac=1.2.3.4-1.2.3.5
Error: Criteria error: Malformed MAC address in criteria
-c ipv4=10:20:30:40:50:60-10:20:30:40:50:66
Error: Criteria error: Malformed IPV4 address in criteria
-c mem=4096-1024
Error: Criteria mem is not a valid range, MIN > MAX.
-c mem=zyx-wvu
Error: Criteria error: Malformed memory size in criteria
-c mem=zyx
Error: Criteria error: Malformed memory size in criteria
7091217:
- Verified that all messages in verifyXML are now wrapped with _().
- Verified that messages in question are displayed correctly.
Ran pylint and pep8.
Build X86 and SPARC gates.
No unit test regressions vs slim_source
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
