Ginnie:

I do not need to make the same change for line 123 and 124 according to Takeshi-san.Only string which has value to i18n is (some of) node.desc. xterm and DEC vt100 had no i18n node.desc. With the mo file provided by Takeshi-san, they did not have any translation.

Thanks !!!




On 06/18/12 01:03 PM, Virginia Wray wrote:
Hi Mary --

Do you need to make the same changes that you made for
line 122 at 123 and 124?

Other than that, looks ok.

ginnie



On 06/18/12 01:36 PM, Mary Ding wrote:
Hi:

Can I get two code reviewers to look at the follow up relating to the G11N message bug 7161787 and this need to be in s11u1_19:

CR: http://monaco.sfbay/detail.jsf?cr=7161787

WPTG_TBT:Lint:CONCAT:Q&A204722-: Solaris 11.1 install_s11 T13Y issue in solaris_install_text_menu.po


Web rev is here and it is based on suggestion from Takeshi Asano and Virginia Wray:

http://jurassic.us.oracle.com/net/osol-bldx.us.oracle.com/datapool/ding/7161787/slim_source/7161787/index.html

There are a couple more uninternationlized strings that I discovered and this also include the code review comment from Virginia Wray.

Testing had been done this way:

1. I confirmed the solaris_install_text_menu.po got the suggested fixes:

#: text-mode-menu.ksh:60 text-mode-menu.ksh:79
msgid "Terminal type (currently %s)"
msgstr ""


#: text-mode-menu.ksh:122
msgid "CDE terminal emulator"
msgstr ""

#: text-mode-menu.ksh:131
msgid "Indicate the type of terminal being used, such as:"
msgstr ""

#: text-mode-menu.ksh:143
msgid "Enter Terminal type [%s]: "
msgstr ""

#: text-mode-menu.ksh:153
msgid "\"%s\" terminal type not supported."
msgstr ""

#: text-mode-menu.ksh:154
msgid ""
"Supported terminal types can be found by using the Shell to list the "
"contents of /usr/gnu/share/terminfo."
msgstr ""


2. Currently, solaris_install_text_menu.mo had not been integrated yet. So I get a Japanese solaris_install_text_menu.mo from Takeshi-san and do a DC build with my install packages and the special solaris_install_text_menu.mo and test as follow

In Japanese, this is what you see:

root@solaris:~# text-mode-menu

Oracle Solaris のインストールメニューへようこそ

1 Oracle Solaris のインストール
2 追加ドライバのインストール
3 シェル
4 端末のタイプ (現在 sun-color)
5 リブート

番号を入力してください[1]: 4

使用中の端末タイプを指定してください。例えば:
dtterm CDE 端末エミュレーター
xterm xterm
vt100 DEC VT100

端末タイプを入力 [sun-color]: junk
端末タイプ junk はサポートされていません。
サポートされている端末タイプを確認するには、シェルを使用して /usr/gnu/share/terminfo の内容を一覧表示します。

端末タイプを入力 [sun-color]:


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to