Jack,

Whenever IPS bumps their API to an incompatible number, we have to move in lockstep with them or everything breaks.

Thanks, everybody, for the review.

-Drew


On 6/18/12 2:10 PM, Jack Schwartz wrote:
Hi Drew.

LGTM.

I verified that pkg is at version 71, so 72 sounds reasonable. I guess we need to walk down the aisle together with ipkg for this one...

    Thanks,
    Jack

On 06/18/12 12:38 PM, Drew Fisher wrote:
Good afternoon!

Could I please get a some eyes on a fast, one-line code review for

7172991 <http://monaco.us.oracle.com/detail.jsf?cr=7172991> install needs update for new pkg api.py version introduced by pli

The diffs are just one line, so I'll put them here:

diff -r 35f43364976e usr/src/lib/install_common/__init__.py.src
--- a/usr/src/lib/install_common/__init__.py.src Fri Jun 15 11:05:42 2012 +0800 +++ b/usr/src/lib/install_common/__init__.py.src Mon Jun 18 13:02:42 2012 -0600
@@ -77,7 +77,7 @@

# global version number for all of the consumers of the pkg5 API in the source
 # tree
-PKG5_API_VERSION = 66
+PKG5_API_VERSION = 72

# Reg-exp to match that a given string would be a valid DTD path for Install
 DTD_PATH_RE = ".*\.dtd\.\d+$"

---

Testing: Mary and I have tested the gate thoroughly. I've run DC against all 5 manifests and verified x86 AI and TI boot, install, reboot and come up correctly. Mary has confirmed SPARC AI and TI also work completely from start to finish. I haven't testing GUI yet, but unless there's a specific need for it, I'll likely defer because it has the same functionality as TI.

Mary also upgraded narn to use the pending IPS bits along with my change. Installadm is fine and can create services and clients without any problems.

Unittests are also clean.

Thanks!

-Drew




_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to