Dave:
Your changes looks fine to me and thank you for fixing the bugs.
On 06/20/12 12:45 PM, Dave Miner wrote:
Consolidating my replies:
On 06/14/12 17:58, Mary Ding wrote:
Dave:
You did not list any testing results with your webrev. Does the
slim_install_unit tests and DC builds works with your fix.
I've built all of the media, run installs with it, verified that there
are no verification failures post-installation that are attributable
to the installers. The boot archive size on both architectures is
approximately the same as with build 18.
The DC unit tests work fine with the update I've done to them.
I also took a look at your webrev and you also took care of the
following bugid 7171984:
Need to remove ibd_upgrade_scripts from dc*xml due to bugid7162546
<http://monaco.us.oracle.com/detail.jsf?cr=7162546>
Can you assign yourself as the RE for 7171984 ???
Done.
On 06/14/12 17:58, Drew Fisher wrote:
> Dave,
>
> boot_archive_configure.py:95
>
> Can you make this behave like the other "touch" calls (121-122,
> 127-128)? I know this isn't you bug, but I noticed it and think we
> should be consistent.
>
Fixed.
> test_boot_archive_configure:192
>
> Bah. Can you nuke the iteration over a single element? :)
>
Fixed.
On 06/14/12 18:23, Karen Tung wrote:
> Hi Dave,
>
> A couple of questions:
>
> 1) I see that you added "etc/notice" to the dc_ai_x86.xml file.
> However, such an entry is not added to dc_text_sparc.xml and
> dc_ai_sparc.xml.
> Should that be added?
>
Actually, it really doesn't need to be in any of them, it's 11K. I've
removed it.
> 2) You didn't mention how you test your changes. Can you elaborate
on that?
>
See above.
A revised webrev is up at
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_7155304-2/webrev/
Thanks,
Dave
On 06/14/12 02:47 PM, Dave Miner wrote:
I'd appreciate a couple of reviewers of the webrev at
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_7155304/webrev/
that addresses
7155304 symlink to usr/bin causes pkg verify failures on installation
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
