Looks ok Mary.
ginnie
On 6/20/12 6:37 PM, Mary Ding wrote:
Sue:
This is what you get when you stay up late until 1:00 a.m. Thanks.
So I had deleted the webrev and upload it again with the correct bugid.
CR: http://monaco.sfbay/detail.jsf?cr=7178327
pep8 regression in transfer/ips.py after fix for 7176734 is integrated.
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7178327
On 06/20/12 05:12 PM, Sue Sohn wrote:
Mary,
The changes look ok, but the bug number you're fixing is 7178327.
Sue
On 06/20/12 04:56 PM, Mary Ding wrote:
Hi
Can I get two code reviewers to look at the following simple pep8
bug fix relating to 7173827:
CR: http://monaco.sfbay/detail.jsf?cr=7173827
pep8 regression in transfer/ips.py after fix for 7176734 is integrated.
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7173827
Testing is done this way:
1. Run pep8 after the fix and confirm it no longer complains
2. Run slim_install_unit test and there is no additional failure.
The result is here and those 97
test failures is there even before my fix
/net/osol-bldx.us.oracle.com//datapool/ding/7178327/slim_source/usr/src/tools/tests/test_result
Thanks !!!
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
