On Wed Jun 27 17:34:01 2012, Jack Schwartz wrote: > Hi Darren. > > Thanks again for your review. > > On 06/27/12 02:21 AM, Darren Kenny wrote: >> Hi Jack, >> >> Looks much better - and more likely to behave as you wanted :) >> >> The only question I have now is w.r.t. the tests themselves - you say you >> did manual testing for expected fails and expected passes, is it possible >> that we could automate for the fail as part of this too? > Failing is simply when lxml validation fails because of a mismatch of > schema vs manifest. This would really be a test of lxml and not of my code. > > I could delete a line from a manifest and watch it fail validation, but > to me there doesn't seem much point in doing that. > > If there's something I'm missing or something else you had in mind > please let me know. >
Nope, that's fine, I just wanted to be sure that there wasn't some benefit to providing such a test. I'm happy with the code as-is then, Thanks, Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
