Hi:
Can I get two code reviewers to look at the following simple js2ai
bug fixes relating to 7180314 and 7057701
CR: http://monaco.sfbay/detail.jsf?cr=7180314
usr/src/cmd/js2ai/modules/conv.py had typo packge
CR: http://monaco.sfbay/detail.jsf?cr=7057701
js2ai results does not show up under link for install_unit_tests
Web rev is here and the fix for 7057701 is suggested by Kristina Tripp:
https://cr.opensolaris.org/action/browse/caiman/md5645/7180314_7057701
Testing had been done this way:
1. For bugid 7180314, before the fix, the js2ai tests fails as
follow and this is the results pointer:
/net/tcu27-01.us.oracle.com//export/home/ding/7180314_7057701/slim_source/usr/src/tools/tests/test_result_without_fix
Without the fix, the js2ai tests fails as follow on tcu27-01 with
s11u1_19:
======================================================================
ERROR: Tests package with delete option
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/hudson/workspace/install_unit_tests/usr/src/cmd/js2ai/modules/test/test_conv.py",
line 1766, in test_package_entry3
self.default_xml, True)
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 407, in __init__
device = match_pattern.group(1)
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 2326, in __process_profile
# based on "any"
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 1680, in __convert_package_entry
return
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 992, in __add_software_data
# are doing an uninstall
KeyError: 'packge'
======================================================================
ERROR: Tests package with understood add option
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/hudson/workspace/install_unit_tests/usr/src/cmd/js2ai/modules/test/test_conv.py",
line 1782, in test_package_entry4
self.default_xml, True)
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 407, in __init__
device = match_pattern.group(1)
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 2326, in __process_profile
# based on "any"
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 1677, in __convert_package_entry
length = len(values)
File
"/export/home/hudson/workspace/install_unit_tests/proto/root_i386/usr/lib/python2.6/vendor-packages/solaris_install/js2ai/conv.py",
line 992, in __add_software_data
# are doing an uninstall
KeyError: 'packge'
----------------------------------------------------------------------
2. After the fix in usr/src/cmd/js2ai/modules/conv.py, the tests now
give the list of package that had problem as follow:
======================================================================
FAIL: Tests package with delete option
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/ding/7180314/slim_source/usr/src/cmd/js2ai/modules/test/test_conv.py",
line 1768, in test_package_entry3
self.profile_failure_report(xml_data, report))
AssertionError:
Resulting XML Tree:
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE auto_install
SYSTEM 'file:///usr/share/install/ai.dtd.1'>
<auto_install>
<ai_instance name="test">
<target>
<logical nodump="true" noswap="false">
<zpool is_root="true" name="rpool">
<vdev name="rpool_vdev" redundancy="none"/>
</zpool>
</logical>
</target>
<software type="IPS">
<destination>
<image>
<!-- Specify locales to install -->
<facet set="false">
facet.locale.*
</facet>
<facet set="true">
facet.locale.de
</facet>
<facet set="true">
facet.locale.de_DE
</facet>
<facet set="true">
facet.locale.en
</facet>
<facet set="true">
facet.locale.en_US
</facet>
<facet set="true">
facet.locale.es
</facet>
<facet set="true">
facet.locale.es_ES
</facet>
<facet set="true">
facet.locale.fr
</facet>
<facet set="true">
facet.locale.fr_FR
</facet>
<facet set="true">
facet.locale.it
</facet>
<facet set="true">
facet.locale.it_IT
</facet>
<facet set="true">
facet.locale.ja
</facet>
<facet set="true">
facet.locale.ja_*
</facet>
<facet set="true">
facet.locale.ko
</facet>
<facet set="true">
facet.locale.ko_*
</facet>
<facet set="true">
facet.locale.pt
</facet>
<facet set="true">
facet.locale.pt_BR
</facet>
<facet set="true">
facet.locale.zh
</facet>
<facet set="true">
facet.locale.zh_CN
</facet>
<facet set="true">
facet.locale.zh_TW
</facet>
</image>
</destination>
<source>
<publisher name="solaris">
<origin name="http://pkg.oracle.com/solaris/release"/>
</publisher>
</source>
<!--
By default the latest build available, in the specified IPS
repository, is installed. If another build is required, the
build number has to be appended to the 'entire' package in the
following form:
<name>pkg:/[email protected]#</name>
-->
<software_data action="install">
<name>
pkg:/entire@latest
</name>
<name>
pkg:/group/system/solaris-large-server
</name>
</software_data>
<software_data action="uninstall">
<name>
pkg:/SUNWzoner
</name>
</software_data>
</software>
</ai_instance>
</auto_install>
Conversion Report:
process errors: 0, warnings: 0, conversion errors: 1, unsupported
items: 0, validation errors: 0
LOG:
test:line 4:CONVERSION: package name translation failed for 'SUNWzoner':
======================================================================
FAIL: Tests package with understood add option
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/ding/7180314/slim_source/usr/src/cmd/js2ai/modules/test/test_conv.py",
line 1784, in test_package_entry4
self.profile_failure_report(xml_data, report))
AssertionError:
Resulting XML Tree:
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE auto_install
SYSTEM 'file:///usr/share/install/ai.dtd.1'>
<auto_install>
<ai_instance name="test">
<target>
<logical nodump="true" noswap="false">
<zpool is_root="true" name="rpool">
<vdev name="rpool_vdev" redundancy="none"/>
</zpool>
</logical>
</target>
<software type="IPS">
<destination>
<image>
<!-- Specify locales to install -->
<facet set="false">
facet.locale.*
</facet>
<facet set="true">
facet.locale.de
</facet>
<facet set="true">
facet.locale.de_DE
</facet>
<facet set="true">
facet.locale.en
</facet>
<facet set="true">
facet.locale.en_US
</facet>
<facet set="true">
facet.locale.es
</facet>
<facet set="true">
facet.locale.es_ES
</facet>
<facet set="true">
facet.locale.fr
</facet>
<facet set="true">
facet.locale.fr_FR
</facet>
<facet set="true">
facet.locale.it
</facet>
<facet set="true">
facet.locale.it_IT
</facet>
<facet set="true">
facet.locale.ja
</facet>
<facet set="true">
facet.locale.ja_*
</facet>
<facet set="true">
facet.locale.ko
</facet>
<facet set="true">
facet.locale.ko_*
</facet>
<facet set="true">
facet.locale.pt
</facet>
<facet set="true">
facet.locale.pt_BR
</facet>
<facet set="true">
facet.locale.zh
</facet>
<facet set="true">
facet.locale.zh_CN
</facet>
<facet set="true">
facet.locale.zh_TW
</facet>
</image>
</destination>
<source>
<publisher name="solaris">
<origin name="http://pkg.oracle.com/solaris/release"/>
</publisher>
</source>
<!--
By default the latest build available, in the specified IPS
repository, is installed. If another build is required, the
build number has to be appended to the 'entire' package in the
following form:
<name>pkg:/[email protected]#</name>
-->
<software_data action="install">
<name>
pkg:/entire@latest
</name>
<name>
pkg:/group/system/solaris-large-server
</name>
<name>
pkg:/SUNWftp
</name>
</software_data>
</software>
</ai_instance>
</auto_install>
Conversion Report:
process errors: 0, warnings: 0, conversion errors: 1, unsupported
items: 0, validation errors: 0
LOG:
test:line 4:CONVERSION: package name translation failed for 'SUNWftp':
----------------------------------------------------------------------
The unit test issues/js2ai issues will be tracked under bugid 7179653.
Test results pointer is here:
/net/tcu27-01.us.oracle.com//export/home/ding/7180314_7057701/slim_source/usr/src/tools/tests/test_result_with_fix
3. As for testing 7057701, this is how testing is done:
I modified the install_unit_tests hudson job with the proposed fix
and the test results links were fine.
http://indiana-build.us.oracle.com/job/install_unit_tests/933/
If you click on the Test Result link, it ran 1776 tests including the
235 js2ai tests. The two test falures were related to js2ai and they
are tracked under bugid 7179653.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
