Karen:
Thanks for fixing this and this looks good to me.
On 06/29/12 03:15 PM, Karen Tung wrote:
Can I get a couple of reviewers to look at my changes for:
7178657
<http://monaco.us.oracle.com/detail.jsf?cr=7178657>text-mode-menu
should determine whether enabling/disabling localized output
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/7178657/webrev/
Even though a lot of lines moved around in
system-install-text-install.mf, the only lines
I added there are:
dir path=usr/lib/install
file path=usr/lib/install/getconsole mode=0555
The other moving around is caused by running "pkgfmt" on the file.
Testing:
----------
- Built both x86 and SPARC text installer ISO with changes.
- Verified that when I boot the ISO up in a physical console,
LC_MESSAGE is set to C,
regardless what language I choose. If I boot up from a serial
console, verified
LC_MESSAGE is not set.
- Went through the whole install to make sure it is successful.
- After first boot, verified that the /usr/lib/install/getconsole is
not on the installed system.
Even though my changes does not touch any existing python files, I ran
slim unit test
just for completeness.
I also made sure the new getconsole PYTHON script I added is pep8 and
pylint clean.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
