NIrmal,
I thought I had replied to this on Friday, but maybe the mail didn't
actually get sent ... sorry.
all_criteria_in_db is optionally provided to the build_query_str()
function so it shouldn't be used indiscriminately here (i.e. it could be
None.) While the only caller of build_query_str() is local to this
file, and it always calls it with all_criteria_in_db passed in, I'd much
rather us to either redefine the arguments appropriately, or check
against the condition.
-ethan
On 07/02/12 04:06, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 reviewers for this simple fix.
Thanks,
Nirmal
On 06/29/12 14:59, Nirmal Agarwal wrote:
Hi all
Can I get review for CR 7169312 :
7169312 install services created on S11 always serve out the default
manifest once server is updated
http://monaco.us.oracle.com/detail.jsf?cr=7169312
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7169312/webrev/
Testing :
1) created a AI service on S11 system with custom manifest
2) upgraded the system to Build 19.
3) updated the install-incorporation from workspace.
4) Booted the client and verified that client gets custom manifest.
Regards
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
