Nirmal: Looks good to me. Can you include test results for your fix ???
----- Original Message ----- From: [email protected] To: [email protected] Sent: Monday, July 2, 2012 7:53:54 PM GMT -08:00 US/Canada Pacific Subject: [caiman-discuss] code review request for 7181235 Hi all, Can I get a review for CR 7181235. 7181235 usr/src/cmd/installadm/installadm_common.py had undefined variable CalledProcessError Since the change is 1 line, please find the diff's . bash-4.1$ hg pdiff diff -r 562056df8c98 -r e9b0490ed3e8 usr/src/cmd/installadm/installadm_common.py --- a/usr/src/cmd/installadm/installadm_common.py Mon Jul 02 12:59:05 2012 -0600 +++ b/usr/src/cmd/installadm/installadm_common.py Mon Jul 02 20:41:49 2012 -0600 @@ -37,7 +37,7 @@ from osol_install.libaimdns import getifaddrs, getboolean_property, \ getstrings_property -from solaris_install import Popen +from solaris_install import Popen, CalledProcessError _ = gettext.translation('solaris_install_installadm', Thanks, Nirmal _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
