Nirmal,
More thoughts on testing. It would be beneficial if you could have the QA group run the installadm
test suites on your code as well as the same manual tests that were run when these changes were
developed for U1. I will send you a separate email with contact info.
Also, if you haven't already (can't tell from your test results), you need to make sure that you can
boot a uefi client from an U1 service.
Sue
On 07/10/12 11:24 AM, Nirmal Agarwal wrote:
Hi all,
Please find the updated webrev and diff webrev :
Webrev:
http://jurassic.us.oracle.com/net/indiana-build.us.oracle.com/export/home/na210770/webrev.uefi/
Diff webrev :
http://jurassic.us.oracle.com/net/indiana-build.us.oracle.com/export/home/na210770/webrev-diff/
rev 0 webrev ( without CR 7173043)
http://jurassic.us.oracle.com/net/indiana-build.us.oracle.com/export/home/na210770/webrev-rev0/
New test done :
I tested unit test mentioned in CR 7173043.
Thanks,
Nirmal
On 7/10/2012 10:54 PM, Nirmal Agarwal wrote:
Hi Kristina,
Thanks for looking at the changes.
On 7/10/2012 9:50 PM, Kristina Tripp wrote:
Nirmal
I haven't finished reviewing these changes but I did notice that there's a
current difference in
dhcp.py versus what's checked into the current slim_gate for one of the changes
you've made that
would be worth investigating just in case the diffs you used weren't up to date.
Your changes:
dhcp.py
1087 if in_host and line.strip().startswith("if ") and \
1088 line.strip().endswith("{"):
1089 # We're entering an if clause inside the host stanza
1090 in_ifclause = True
1091 if in_host and line.strip().endswith("}"):
1092 if in_ifclause:
1093 # We're at the end of the if clause, clear the flag.
1094 in_ifclause = False
1095 else:
current slim_source for this
if in_host and line.strip().endswith("}"):
if in_ifclause:
# Read next line and make sure we are at end of
# if-else clause.
next_line = current_cfg[index + 1].strip()
if not next_line.startswith("else"):
# We're at the end of the if clause,
# clear the flag.
in_ifclause = False
# In case of update client, update
# bootfile information.
if stanza and found:
hostlines.append(" {0} \n".format(
stanza.bootfile_clause))
continue
else:
This corresponds to CR 7173043 (dhcp smf service goes into maintenance after
delete-client). I was
in the impression that we can only backport escalated CR's to SRU gate
which is wrong. I will make this change.
Thanks,
Nirmal
On 07/10/12 06:38 AM, Nirmal Agarwal wrote:
Hi all
Can I please get review for backport of "UEFI and Grub support for installadm"
for SRU gate.
7155522 Install needs to support UEFI & GPT (phase I)
7047968 installadm should utilize pybootmgt
7126748 installadm create-client generates unwanted error message if DHCP
service is not configured
7085736 Remove pybootmgmt from slim_source
7181827 create manual dependency for boot-management on system/library/install
package
Please find the webrev at the below location :
http://jurassic.us.oracle.com/net/indiana-build.us.oracle.com/export/home/na210770/webrev.uefi/
Pep8 : clean
Ran pylint to check for errors.
Slim-test output:
/net/indiana-build.us.oracle.com/export/home/na210770/uefi/slim-test-op
Manual Testing :
/net/indiana-build.us.oracle.com/export/home/na210770/uefi/Manual-Testing
Thanks,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
