On 12/07/2012 15:13, Mary Ding wrote:
Niall:

I believe there is a typo for "customisation"

It probably should be:
customization
Translate to American - will do ;)

Thanks Mary

Niall



----- Original Message -----
From: [email protected]
To: [email protected]
Cc: [email protected]
Sent: Thursday, July 12, 2012 1:49:26 PM GMT -08:00 US/Canada Pacific
Subject: Re: [caiman-discuss] Code review request for sparc boot unit tests (7156661)

Niall:

Thanks for fixing this and LGTM. I had already tried the fix from Niall and it works.


----- Original Message -----
From: [email protected]
To: [email protected]
Sent: Thursday, July 12, 2012 1:40:35 PM GMT -08:00 US/Canada Pacific
Subject: [caiman-discuss] Code review request for sparc boot unit tests (7156661)

Hi,

Can I ask for a code review for this very short fix for 715661
\
http://monaco.sfbay.sun.com/detail.jsf?cr=7156661

install unit tests fails on sparc after UEFI/GRUB2/Large Disk Boot went in

The fix is simply to skip ISO boot unit tests on sparc as none of the features tested (boot entries, timeout and custom boot entries) are applicable on SPARC. They are specific to GRUB/X86

pylint/pep8 clean

Webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-7156661/

Thanks,
Niall

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to