On 07/17/12 11:47 AM, Swati Sarraf wrote:
Hi All,
Can I have a code review for the following bug fix:
7183018 Gui livecd is not using size from image.info but using fallback image
size
http://monaco.us.oracle.com/detail.jsf?cr=7183018
Webrev link:
https://cr.opensolaris.org/action/browse/caiman/ssarraf/7183018/
Testing is done as follow:
1. Slim test done
Ran 1901 tests in 353.236s, FAILED (SKIP=1, failures=1)
failed test: Tests package with understood add option
Slim test pointer: file:///net/osol-bldx/datapool/ssarraf/7183018/
2. Pylint and pep8 test done , result OK
pylint result pointer: file:///net/osol-bldx/datapool/ssarraf/7183018/
3 Created DC image and tried installation with minimum size (4.7GB).
Installation finished successfully.
-Thanks
Swati Sarraf
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Swati,
I had all the same comments as Karen, plus a few more nits:
651 No need for backslash.
652 Should be indented so that "Size.mb_units is lined up with str on line above
654
if its fail
->
if it fails
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
