Sreedhar: You need to update the target release for 6995697.
Also need to provide introduced release and build for all these CRs. You also did not say how you test the fix for 7123812l Besides pep8, you need to run pylint as well. ----- Original Message ----- From: [email protected] To: [email protected] Sent: Wednesday, September 12, 2012 8:37:53 PM GMT -08:00 US/Canada Pacific Subject: [caiman-discuss] Code Review request for CR-6995697, 7182312, 7187992, 7188029 Hi Could you please review the following test suite fixes 6995697 /var/tmp/install directory not removed by logging tests, tests fail 7182312 extra slash in output when AI install fails 7187992 lib/install_manifest_input/test leaves /tmp/tmp* file behind. 7188029 lib/install_transfer/test leaves /tmp/test_dir_excl_list file, need to remove it. Webrev: http://jurassic.us.oracle.com/net/scapen-csx11u1-0/scratch/schalama/on12_7188029/webrev/ Tests Performed: - Executed "./slim_test lib/solaris_install/manifest_input/test", deleted /tmp/tmpxxxxxx files successfully. - Executed "./slim_test lib/solaris_install/transfer/test", deleted /tmp/test_dir_excl_list file successfully. - Executed "./slim_test lib/solaris_install/test/test_logger.py", deleted /tmp/installLog, /var/tmp/install, /var/tmp/installLog directories successfully. - Pep8 - clean - Nightly build completed successfully Thanks Sreedhar
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
