I still think squashing is very important, and essentially required by several rfcs.
On 6/1/16 3:02 AM, Kevin Darbyshire-Bryant wrote: > To try and keep everyone in the loop this has also been sent to the cake > list. > > LR;DR - There's a pull request to the LEDE tree to integrate cake as a > patch to tc as well as a small, separate core package for > kmod-sched-cake. This is a good thing. The pull request is > https://github.com/lede-project/source/pull/72 > > Hannu Nyman is the author of the patch included in the PR - I've > volunteered to be maintainer until cake really, really, really goes > upstream. Lucky me :-) > > Hannu's patch included an improvement in column alignment on tc -s qdisc > show output. I have updated Dave's tc-adv tree to include this cosmetic > change > https://github.com/dtaht/tc-adv/commit/54794117daef5dd16e0ccec4b821f0c67e6b9ede > > > Jonathan made reference to "a particular misfeature that should be > deleted". This mis-feature is DSCP washing. This has been brought up > before and to that end I put in some pull requests removing said > facility to Dave's cake & tc-adv repos. On that previous occasion it > was decided it could stay but again it has been mentioned as being > something undesirable. I dug around, found my previous 'nosquashwash' > trees, rebased them and have submitted pull requests again. > > https://github.com/dtaht/tc-adv/pull/10 > https://github.com/dtaht/sch_cake/pull/25 > > Maybe it will save a little work. Or if JM happy I will commit them as > is. I personally would like this stumbling block removed for better or > for worse, let's not stumble over it again :-) > > Kevin > > > > > > On 31/05/16 19:46, Hannu Nyman wrote: >> I have amended the commit (and it is rebased to the current LEDE head) >> >> * import the cake commit recommended by @chromi >> <https://github.com/chromi> >> * define Kevin as the maintainer for cake, thanks @kdarbyshirebryant >> <https://github.com/kdarbyshirebryant> >> >> @kdarbyshirebryant <https://github.com/kdarbyshirebryant> , regarding >> maintenance: >> >> * The cake part is easily maintainable, as the Makefile here just >> defines the commit to be fetched from the original cake repo and >> sets date as the version. >> * tc patch may require some manual diff work if the later changes in >> tc-adv are complex. I actually created my patch a few months ago by >> making a diff of your tc-adv4.3 branch (that contained tc-adv >> applied to iproute 4.3) to plain iproute. Then I pruned the >> non-essential parts (e.g. extra/old cake versions still present in >> tc-adv, changes to other qdiscs, man pages etc.) from the patch and >> left only the cake stuff to be compiled. And that was not actually >> very much. Basically just a new module for tc, small changes to a >> header file and Makefile. I have since then updated the patch to >> include the two commits from @chromi <https://github.com/chromi> in >> April. >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <https://github.com/lede-project/source/pull/72#issuecomment-222782884>, >> or mute the thread >> <https://github.com/notifications/unsubscribe/AGMuq2vMBhtdKSJEZTkLXTVLdqomM63hks5qHIINgaJpZM4IqaPW>. >> >> > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake _______________________________________________ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake