> On 28 Feb 2019, at 09:54, Toke Høiland-Jørgensen <t...@redhat.com> wrote: > >> I also equally aware that this is ‘creeping featuritis’ and doing >> nothing to speed cake up… > > Yeah, this is the crux of the issue, really: it's a tradeoff between > ease of use and featuritis. Now in this case the actual impact is a > single check it might actually be acceptable > >> actually I may have improved BESTEFFORT a little - we no longer look >> for matching TC Major numbers if there’s no actual choice of tin to be >> made :-) > > Well, you made the besteffort case slightly faster, but every other mode > slightly slower... :)
Ah, ok, tc filter really is king ;-) > > If you are going to send a patch (or pull request), please leave out the > refactoring, and only include the feature. This makes it easier to see > the impact of the feature addition on its own. Ha ha, sending a patch to the kernel lists??? Never again! The non-refactored version is https://github.com/ldir-EDB0/sch_cake/commit/f30bb18adc97c827c81c9a3297ab14bfaf2adcb0 and I’ve created a PR > > Also, I assume you have a companion patch for iproute2 somewhere? In the first email: https://github.com/ldir-EDB0/tc-adv/commits/fwmark - based on 4.20.0 ‘cos that’s where openwrt is at the moment. When I’ve found a suitable editor I was even going to update the man page! > > -Toke Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A _______________________________________________ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
