[
https://issues.apache.org/jira/browse/CB-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203397#comment-13203397
]
Shazron Abdullah commented on CB-242:
-------------------------------------
Thanks Matthew! please send a pull request to the main repo you forked off
(ideally send a pull request from a branch that contains your changes only, not
master - else the pull req could be moving target). Currently the notification
system does not work - so once you send the pull request, if you could comment
in this issue so I can be notified that would be great.
I attempted this sometime ago, but other pressing issues took priority. I'll
review and test, and commit your changes if all goes well.
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>
> Key: CB-242
> URL: https://issues.apache.org/jira/browse/CB-242
> Project: Apache Callback
> Issue Type: Improvement
> Components: iOS
> Reporter: Matthew Lanham
> Assignee: Shazron Abdullah
> Priority: Minor
> Fix For: 1.5.0
>
>
> We have been manually building each time a release is out to avoid this,
> often we have libs in our iOS project that also package the Reachability
> class, it seems like that renaming it is painless and causes no adverse
> affects, i have forked the GitHub project and made a commit of our proposed
> changes, i wondered if someone could consider this being available in the
> main repo.
> See commit here:
> https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
