If it's passing tests, let's add the new cordova.js file to the incubator-cordova-blackberry-webworks repo and change over the native JS calls to use require. Then we're done with BB! Tim should be helping out with this too (as soon as he gets a physical device on hand). But I think we're pretty much there, eh Drew?
On 12-02-15 8:53 AM, "Drew Walters" <[email protected]> wrote: >Ok, I've submitted a pull request with my changes. > >https://github.com/callback/callback-js/pull/17 > >In my previous email, #3 was due to where I had inserted #2 (oops). >The changes are mostly phonegap -> cordova changes. Additionally I >had to fix a module require in lib/platform/blackberry.js which was >specifying a bad module name. > >The only appearance of phonegap in common-js after my change is in the >iOS and WP7 plugins where they reference native code since I didn't >think those had been renamed yet. > >Eventually the BlackBerry native side should make use of require (as >shown in Fil's commit), but that will wait till common-js gets added >to apache source. For the time being a quick hack is to add the >following at the bottom of the generated js: > >var Cordova = require('cordova'); > >On Wed, Feb 15, 2012 at 9:23 AM, Drew Walters <[email protected]> wrote: >> So I've got callback-js "working" in my sandbox. Haven't submitted >> pull request yet because I'm still debugging something. Here's >> summary of changes I've made: >> >> 1. Modify rest of files to use "cordova" instead of "phonegap". >> 2. Added a global define of "Cordova" as a temporary hack since native >> PluginResult.toSuccessCallbackString expects it to exist. >> 3. For some reason I had to make sure the cordova/utils module exists >> in cordova.js before the cordova/channel module, otherwise I was >> getting an error that the module didn't exist. >> >> With the above changes I was able to run some simple tests (verified >> network works). I'm currently looking at proper fix for #2 and #3. >> >> On Wed, Feb 15, 2012 at 8:21 AM, Drew Walters <[email protected]> >>wrote: >>> I'm looking at https://github.com/callback/callback-js and I see a lot >>> of references to "phonegap" in the lib/plugins directory though it >>> seems like things one directory up (lib) has been changed. Am I not >>> looking at an up to date project or should I send a pull request with >>> that name change too? >>> >>> On Wed, Feb 15, 2012 at 8:17 AM, Gord Tanner <[email protected]> >>>wrote: >>>> I am on BlackBerry today. >>>> >>>> Currently showing: >>>> Error: SyntaxError: Unable to parse JSON string alert. >>>> >>>> I will attempt to get it up and running again today. >>>> >>>> I also have the start of a node runner for callback-js tests here: >>>> https://github.com/gtanner/callback-js >>>> >>>> Gord >>>> >>>> On Wed, Feb 15, 2012 at 5:19 AM, Viras <[email protected]> >>>>wrote: >>>> >>>>> Can you please drop me a line once cordova-js is on the official >>>>>repos & >>>>> mirrored? I will then give integrating the new common-JS into >>>>>cordova-qt a >>>>> go! >>>>> >>>>> Am 2012-02-15 00:09, schrieb Filip Maj: >>>>> >>>>> Update on unified JavaScript work in cordova for today: >>>>>> >>>>>> - looks like the WP7 implementation cannot run our mobile-spec, >>>>>>which is a >>>>>> hurdle in making sure it supports the cross-platform cordova API. >>>>>>Before >>>>>> we can move forward with cordova-js integration we really need to >>>>>>figure >>>>>> that part of it out. >>>>>> - I will work rest of day in getting cordova-js into the apache git >>>>>>repo >>>>>> and finishing up that work. >>>>>> - BlackBerry still needs work and testing - Tim, you available? >>>>>> - Shaz and I have a remote hack sesh planned for tomorrow morning >>>>>>to get >>>>>> iOS on track. Will have a better idea how that platform is looking >>>>>> tomorrow. >>>>>> - Bada 2.0 still needs a platform implementation before we can move >>>>>>with >>>>>> cordova-js on it. >>>>>> >>>>> >>>>> -- >>>>> GOFG - Get On Fat Guy >>>>> http://www.gofg.at/ - powered by Cordova >>>>> >>>> >>>> >>>> >>>> -- >>>> Gord Tanner >>>> Senior Developer / Code Poet >>>> tinyHippos Inc. >>>> @tinyhippos
