Nice job Joe, that is rad! So stoked to see it working well across ICS and Gingerbread.
On 12-02-17 4:34 PM, "Joe Bowser" <[email protected]> wrote: >Hey > >I got this down to 26 failed tests on ICS after overriding FileError. > There seems to be issues with the DirectoryReader as well, but at least >it's only 5 failures more than Gingerbread. I pushed it up to the >repository. > >Joe > >On Fri, Feb 17, 2012 at 3:45 PM, Filip Maj <[email protected]> wrote: > >> Awesome Bryce that is great! Super stoked to see it in there finally. >> >> There were more bugs that came up in Android 4.0+. Looks like some of >>the >> File API objects exist "natively" in ICS's WebView. The "common" >>platform >> definition (under lib/platform/common.js) specifies most of the objects >>we >> need to exist in global scope for the Cordova API to work - but - the >>way >> we drop the common objects into global scope is we don't overwrite those >> objects if they already exist in global scope. With ICS implementing >>some >> of them (like DirectoryEntry!) we need to either: >> >> A) test out the native implementations in ICS and see if they're >> functional, or >> B) add overrides in lib/platform/android.js for the objects affected. >>The >> platform-specific js definitions *always* clobber whatever exists so >>it's >> one way of just forcing out polyfills into the JS env (see 'device' and >> how that is defined in android's platform .js file). >> >> On 12-02-17 3:38 PM, "Bryce Curtis" <[email protected]> wrote: >> >> >Android is running on common-js! >> > >> >Native side has been updated with merge from Fil. >> >JS side was built from callback/callback-js and saved in assets/js. >> > >> >Now it's time to test and work through bugs. (Including command line >> >scripts) >> >Running on Droid 2.2.3, I see 21 failed tests. >> > >> >Any word on when cordova-js repository on apache will be created? >>Would >> >be >> >good to get it there asap. >> > >> > >> >On Fri, Feb 17, 2012 at 2:04 PM, Filip Maj <[email protected]> wrote: >> > >> >> Thanks Bryce! >> >> >> >> On 12-02-17 11:59 AM, "Bryce Curtis" <[email protected]> wrote: >> >> >> >> >I'll take a look at it. >> >> > >> >> >On Fri, Feb 17, 2012 at 1:55 PM, Simon MacDonald >> >> ><[email protected]>wrote: >> >> > >> >> >> I'm off on vacation, in fact I'm already supposed to be gone, >>until >> >> >> Tuesday. On Tuesday I'll be giving a presentation at a local >>collage. >> >> >> Wednesday is meetings so I wouldn't be able to look at it until >>next >> >> >> Thursday. >> >> >> >> >> >> Simon Mac Donald >> >> >> http://hi.im/simonmacdonald >> >> >> >> >> >> >> >> >> On Fri, Feb 17, 2012 at 2:52 PM, Filip Maj <[email protected]> wrote: >> >> >> >> >> >> > Hey all, >> >> >> > >> >> >> > Android is ready to integrate. Currently about 15 mobile spec >>tests >> >> >>are >> >> >> > failing - better than the 23 or so that are failing with the >> >>current >> >> >> > android implementation :) >> >> >> > >> >> >> > Things we need to do: >> >> >> > >> >> >> > - merge in my "unified-js" branch of the android implmentation: >> >> >> > >> https://github.com/filmaj/incubator-cordova-android/tree/unified-js >> >> >> > - axe all javascript related stuff from the android repo: from >> >>build >> >> >> > scripts, .js files, etc. >> >> >> > - use latest cordova-js, run a build, grab the android JS, and >>add >> >> >>that >> >> >> to >> >> >> > the android repo. >> >> >> > >> >> >> > Can someone from Android land (Simon, Joe) do the above steps, >> >>please? >> >> >> > >> >> >> > Next I'm hopping on iOS as we are behind in getting that >> >> >>implementation >> >> >> up >> >> >> > to speed with cordova-js. BlackBerry still needs t some help >>too. >> >> >> > >> >> >> > Inching ever closer... >> >> >> > >> >> >> > >> >> >> >> >> >> >> >> >>
