Committed my cordova-js WP7 code and sent a pull-req. taggable from my end.
On Thu, Apr 5, 2012 at 5:45 PM, Shazron <[email protected]> wrote: > Is cordova-js ready? I can tag it, but don't know if it is. > > On Thu, Apr 5, 2012 at 5:16 PM, Joe Bowser <[email protected]> wrote: > > OK, still need cordova-js tagged before I can do the build and tag > Android. > > > > On Thu, Apr 5, 2012 at 4:54 PM, Simon MacDonald > > <[email protected]>wrote: > > > >> Fix just checked in for CB-453. > >> > >> Simon Mac Donald > >> http://hi.im/simonmacdonald > >> > >> > >> > >> On Thu, Apr 5, 2012 at 7:50 PM, Joe Bowser <[email protected]> wrote: > >> > Is this fixed in iOS? I checked cordova-js, and I think the bug is in > >> > there, namely the fact that foo.length is the number of characters, > not > >> the > >> > number of bytes in a string, thus the offset will always be wrong > >> whenever > >> > you are writing binary data to a file, which is what Android does in > its > >> > write and truncate. > >> > > >> > On Thu, Apr 5, 2012 at 4:08 PM, Simon MacDonald > >> > <[email protected]>wrote: > >> > > >> >> The bug was discovered after Becky updated the file test cases. I > have > >> not > >> >> had the chance to Jira it yet as I've run home for supper. > >> >> > >> >> Simon > >> >> On Apr 5, 2012 7:03 PM, "Joe Bowser" <[email protected]> wrote: > >> >> > >> >> > Also, does this bug have a corresponding test in mobile-spec? > >> >> > > >> >> > On Thu, Apr 5, 2012 at 4:02 PM, Joe Bowser <[email protected]> > wrote: > >> >> > > >> >> > > What bug is this? Is it in JIRA? > >> >> > > > >> >> > > > >> >> > > On Thu, Apr 5, 2012 at 3:51 PM, Simon MacDonald < > >> >> > [email protected] > >> >> > > > wrote: > >> >> > > > >> >> > >> I have a bug fix for writing Chinese characters to check in on > >> >> Android. > >> >> > So > >> >> > >> please don't tag it until I can get it in. > >> >> > >> > >> >> > >> Simon > >> >> > >> On Apr 5, 2012 6:19 PM, "Joe Bowser" <[email protected]> wrote: > >> >> > >> > >> >> > >> > Hey > >> >> > >> > > >> >> > >> > I'm wanting to tag 1.6.0. I am currently following the wiki > >> article > >> >> ( > >> >> > >> > http://wiki.apache.org/cordova/AndroidReleaseChecklist), and > it > >> >> looks > >> >> > >> like > >> >> > >> > I need the Cordova-JS to be tagged first. What do things look > >> like > >> >> > >> right > >> >> > >> > now w.r.t. this? > >> >> > >> > > >> >> > >> > Joe > >> >> > >> > > >> >> > >> > >> >> > > > >> >> > > > >> >> > > >> >> > >> >
