[
https://issues.apache.org/jira/browse/CB-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256707#comment-13256707
]
Patrick Mueller commented on CB-530:
------------------------------------
Since you mention "added jshint as an npm module", we probably need to decide
what we're going to do about these npm modules we are pre-req'ing.
For weinre, they're stored in git, and I should be "shrinkwrapping" them as
well [1], but am not right now. Lots of upsides to this, one big downside:
since the modules are stored in Apache's git, they need to have LICENSEy bits
applied. See [2] for what I'm doing in weinre. Note that you need to add the
LICENSEy bits recursively, to packages that the packages we explicitly pre-req,
pre-req.
Alternatively, we can do what we do now, which is to just say "run `npm
install` before doing your build (or whatever it is we do). It's not
completely clear to me if this is really kosher wrt: Apache-ness or not, but
since this goop isn't (currently) shipped in our runtimes, only used to build
our runtimes, it's less sensitive to the "everything must be in the SCM" mantra.
[1] http://npmjs.org/doc/shrinkwrap.html
[2] https://github.com/apache/incubator-cordova-weinre/blob/master/LICENSE#L205
> Run jslint/jshint in cordova-js every time you build
> ----------------------------------------------------
>
> Key: CB-530
> URL: https://issues.apache.org/jira/browse/CB-530
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.7.0
>
>
> Just to catch simple syntax errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
