I should be able to get most of these changes this week. After looking the Blackberry code, I need to redo the Android patch. I'll look at WP7 tomorrow. Symbian, Bada, et al may be more challenging since I don't have test devices.
On Tue, May 15, 2012 at 11:56 AM, Filip Maj <[email protected]> wrote: > Sure. Thanks for taking the lead on this one Don. With your help we should > be able to get this in for 1.8, possibly even for the RC (presumably later > this week?) > > On 5/14/12 8:20 PM, "Don Coleman" <[email protected]> wrote: > >>Should I create an JIRA ticket for this? >> >>https://github.com/don/incubator-cordova-mobile-spec/tree/FileTransferErro >>r >>https://github.com/don/incubator-cordova-ios/tree/FileTransferError >>https://github.com/don/incubator-cordova-android/tree/FileTransferError >> >>I need to clean up the Android version before issuing a pull request. >> >>I'll take a look at WP7 tomorrow. >> >>On Mon, May 14, 2012 at 3:00 PM, Joe Bowser <[email protected]> wrote: >>> +1 >>> >>> On Mon, May 14, 2012 at 11:54 AM, Shazron <[email protected]> wrote: >>> >>>> +1 >>>> >>>> On Mon, May 14, 2012 at 11:56 AM, Filip Maj <[email protected]> wrote: >>>> > +1 ! >>>> > >>>> > On 5/14/12 11:50 AM, "Simon MacDonald" <[email protected]> >>>> wrote: >>>> > >>>> >>Sounds good to me. I'd probably skip the "http_message" as you pretty >>>> much >>>> >>get all you need from the status and you don't need to localize the >>>> >>string. >>>> >> >>>> >>Simon Mac Donald >>>> >>http://hi.im/simonmacdonald >>>> >> >>>> >> >>>> >>On Mon, May 14, 2012 at 9:29 AM, Don Coleman <[email protected]> >>>> >>wrote: >>>> >> >>>> >>> I'd like to add HTTP Status Code and HTTP Status Message to >>>> >>> FileTransferError. >>>> >>> >>>> >>> Any objections? >>>> >>> >>>> >>> { >>>> >>> "code": FILE_NOT_FOUND_ERR >>>> >>> "source": "http://example.com/missing.txt", >>>> >>> "target": "file:///mnt/sdcard/foo.txt", >>>> >>> "http_status": 404 >>>> >>> "http_message": "Not Found" >>>> >>> } >>>> >>> >>>> >>> { >>>> >>> "code": CONNECTION_ERR >>>> >>> "source": "http://example.com/protected.txt", >>>> >>> "target": "file:///mnt/sdcard/bar.txt", >>>> >>> "http_status": 401 >>>> >>> "http_message": "Authorization Required" >>>> >>> } >>>> >>> >>>> >>> { >>>> >>> "code": CONNECTION_ERR >>>> >>> "source": "http://example.com/admin.txt", >>>> >>> "target": "file:///mnt/sdcard/baz.txt", >>>> >>> "http_status": 403 >>>> >>> "http_message": "Forbidden" >>>> >>> } >>>> >>> >>>> > >>>> >
