[ 
https://issues.apache.org/jira/browse/CB-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397226#comment-13397226
 ] 

Simon MacDonald commented on CB-572:
------------------------------------

As I prototyped this today I came to the conclusion that we may not want to do 
this. If we move all the code out of DroidGap and into the SplashScreen plugin 
we have a timing issue as the SplashScreen plugin may not be loaded when the 
main activity wants to show the splash screen even if the plugin has the onload 
attribute set to true. 

Additionally, in order to do this correctly as a plugin we will need to add 
more methods to CordovaInterface which is something Joe is already finding 
onerous when you want to implement that interface. For folks that want to embed 
a CordovaWebView in their own activity they are probably taking care of the 
splash screen themselves. So, keeping this in DroidGap for folks who don't want 
to worry about embedding the web view kinda makes sense. 
                
> Refactor the Splashscreen API so that the code is outside of DroidGap
> ---------------------------------------------------------------------
>
>                 Key: CB-572
>                 URL: https://issues.apache.org/jira/browse/CB-572
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: 1.7.0
>            Reporter: Joe Bowser
>            Assignee: Simon MacDonald
>             Fix For: 1.9.0
>
>
> It would make more sense if we had the code in the plugin somehow, and added 
> the necessary methods to CordovaInterface.  This way we can keep things more 
> consistent to those who have the unfortunate task of combining DroidGap with 
> a MapActivity.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to