+1 wait until 2.0.0 is out then push the change.
Simon Mac Donald http://hi.im/simonmacdonald On Mon, Jul 16, 2012 at 3:01 PM, Filip Maj <[email protected]> wrote: > Andrew, > > Thanks a lot for this! This is a lot of work and it's great that you > tackled this across a couple of platforms, too. > > Agree with you that since the RC is out for 2.0, let's wait until we land > 2.0 proper end of this week before we merge your changes into the master. > > Usually, a committer would push these sorts of pending changes to a topic > branch on the related repositories. We essentially have this already in > place, the branches simply exist on your GitHub fork :) > > I'll keep a reference to this mail in my inbox and we'll revisit / merge > next week. Sound good? > > On 7/16/12 11:26 AM, "Andrew Grieve" <[email protected]> wrote: > > >I've got a set of pull requests to do so, and just wanted to make sure > >everyone knows that they are all related: > > > >JS: https://github.com/apache/incubator-cordova-js/pull/20 > >Android Impl: https://github.com/apache/incubator-cordova-android/pull/33 > >iOS Impl: https://github.com/apache/incubator-cordova-ios/pull/35 > >Mobile-Spec Impl: > >https://github.com/apache/incubator-cordova-mobile-spec/pull/9 > >Docs: https://github.com/apache/incubator-cordova-docs/pull/24 > > > >I didn't update the cordova.js files in the Andoid/iOS changes since I > >thought maybe they'd change while these are pending, and wasn't sure if it > >was normal to update the JS on every platform every time > >incubator-cordova-js changes. > > > >Also - I know a 2.0 candidate is now tagged so probably this change will > >wait until after the release is done? Or does development continue on and > >changes are cherry-picked into a release branch? > > > >Andrew > >
