[
https://issues.apache.org/jira/browse/CB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446141#comment-13446141
]
Andrew Grieve commented on CB-625:
----------------------------------
I spent the morning trying this out on the iOS codebase. Results are here:
https://github.com/agrieve/incubator-cordova-ios/commits/uncrustify
Given the varying opinions on this, I think we should test this out for a while
just on the iOS codebase.
I'm not worried about messing up the blame history, because it's already pretty
bad in terms of random lines being changed every once in a while. It's also not
hard to go back in time via github to see how blame changes over time.
The change includes a pre-commit hook. Another option we have is for committers
to run uncrustify and then --amend when patching in changes. I don't love this
though as it will get hairy when dealing with multi-commit changes.
Anyways, not going to merge this until I get another nod from you Shaz. Also
will wait until 2.1.0 is over with.
> Run uncrustify on source code. It's getting a bit hairy in there (tabs vs
> spaces, etc, amongst other annoyances)
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CB-625
> URL: https://issues.apache.org/jira/browse/CB-625
> Project: Apache Cordova
> Issue Type: Task
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Andrew Grieve
> Priority: Minor
> Fix For: 2.2.0
>
>
> Project Github: https://github.com/bengardner/uncrustify
> See: https://github.com/tonyarnold/Xcode-4-Uncrustify-Automator-Services
> Install through Homebrew: brew install uncrustify
> Sample config file: https://gist.github.com/261662/
> Setting component to iOS, but can be applied to Java (Android, BB) and C#
> (WP7) as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
