[
https://issues.apache.org/jira/browse/CB-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458599#comment-13458599
]
Patrick Mueller commented on CB-1494:
-------------------------------------
re: using last element of the XFF header as remoteAddress: +1 - let's try that
for now and tweak later if we need to. Unfortunately, your regex matcher in
resolveRemoteAddressFrom() is not correct; it needs to parse against commas as
well. The article
http://rod.vagg.org/2011/07/wrangling-the-x-forwarded-for-header/ seems to have
some regexes in there, I didn't look at them to see if they'd be appropriate
(or correct).
re:xss on the value. If we can ensure the new remoteAddress will never contain
any HTML, because we've done a great job parsing it, then I'm not concerned
about XSS. Otherwise I am. I wouldn't necessarily consider this to be another
bug. Highly related, I'm happy to keep a bunch of highly related changes
together in one batch. But if that's the way you'd like to roll, fine.
re: multiuser.html fix. Again, all lumped into a single pull request, or
separate; in this bug, or new bug. I prefer keeping everything like this
together, minimize the # of pull requests and bugs.
re: test cases, yes; new bug sounds good.
re: doc, excellent! again, do whatever. new bug :-)
> Supports running server behind a proxy, such as Heroku Cedar
> ------------------------------------------------------------
>
> Key: CB-1494
> URL: https://issues.apache.org/jira/browse/CB-1494
> Project: Apache Cordova
> Issue Type: New Feature
> Components: weinre
> Reporter: Patrick Mueller
> Assignee: Patrick Mueller
>
> created for https://github.com/apache/incubator-cordova-weinre/pull/10
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
