Okay, fixed the test by converting some wait()s to waitFor()s.
On Thu, Sep 20, 2012 at 10:56 PM, Andrew Grieve <[email protected]> wrote: > Well, sorry for the false accusation :(. Looks like the test is just > flakey: > > geolocation getCurrentPosition position acquisition > it should fire error callback with TIMEOUT code after timeout period has > elapsed and no position is available > Error: Expected spy error to have been called with [ { code : 3, message > : 'Position retrieval timed out.' } ] but it was never called. > at new jasmine.ExpectationResult (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/thirdparty/jasmine/jasmine.js:102:32) > at jasmine.Matchers.matcherFn_ [as toHaveBeenCalledWith] > (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/thirdparty/jasmine/jasmine.js:1171:29) > at geo.getCurrentPosition.timeout (eval at <anonymous> > (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/test/runner.js:84:21)) > at jasmine.Block.execute (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/thirdparty/jasmine/jasmine.js:1001:15) > at jasmine.Queue.next_ (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/thirdparty/jasmine/jasmine.js:1790:31) > at jasmine.Queue.next_.onComplete (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/thirdparty/jasmine/jasmine.js:1786:18) > at Object.jasmine.WaitsBlock.execute [as _onTimeout] > (/Users/agrieve/Google > Drive/macfiles/git/incubator-cordova-js/thirdparty/jasmine/jasmine.js:2231:5) > at Timer.list.ontimeout (timers.js:101:19) > > it fails for me most times, but does pass every once-in-a-while. I'll have > a look and see if I can figure out what's up with it. > > > On Thu, Sep 20, 2012 at 10:46 PM, Andrew Grieve <[email protected]>wrote: > >> Hey Joe, >> >> Looks like your "Fixing CB-1498" commit to the js repo causes jake to >> fail a unit test. I'll fix it up, but might be a sign that maybe you didn't >> run the tests before checking in? It would also be helpful if you could >> rebase before committing and write a description and [platform] in the >> commit message instead of just the bug id. >> >> >
