Sounds reasonable On 9/26/12 12:01 PM, "Andrew Grieve" <agri...@chromium.org> wrote:
>wait() and waitFor() calls require you to pass in the timeout. Are there >any places where the timeout is taken from a global value? Otherwise, I'm >wondering if we should just make the File tests have a longer timeout, and >use a small timeout everywhere else. (perhaps FileTransfer as well) > > >On Wed, Sep 26, 2012 at 2:58 PM, Filip Maj <f...@adobe.com> wrote: > >> The file tests. Some of them need this, esp the tests that nest 3-4 >> callbacks together. >> >> Run the full suite of tests on old android devices and you'll see what I >> mean :) >> >> On 9/25/12 12:19 PM, "Becky Gibson" <gibson.be...@gmail.com> wrote: >> >> >No objections to making it shorter but I think iOS is the reason for >>the >> >longer timeouts. If you do change the timeouts please test on an >>actual >> >iOS device (or give me a shout and I can try it on an iPhone 4s and >>ipad 2 >> >both running iOS 6. >> > >> >-becky >> > >> >On Tue, Sep 25, 2012 at 1:18 PM, Andrew Grieve <agri...@google.com> >> wrote: >> > >> >> autotest/test-runner.js: >> >> >> >> // Timeout is 2 seconds to allow physical devices enough >> >> > // time to query the response. This is important for some >> >> > // Android devices. >> >> > var Tests = function() {}; >> >> > Tests.TEST_TIMEOUT = 7500; >> >> >> >> >> >> The really long timeout is pretty annoying. Any objections to trying >>to >> >>set >> >> this back to 2 seconds? >> >> >> >>